Skip to content

Conversation

benjaminglass1
Copy link
Collaborator

@benjaminglass1 benjaminglass1 commented Jul 18, 2025

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Jul 18, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158686

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 1 Pending

As of commit dccba09 with merge base 4840a1a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@benjaminglass1 benjaminglass1 added the release notes: build release notes category label Jul 18, 2025
@benjaminglass1 benjaminglass1 self-assigned this Jul 18, 2025
@benjaminglass1 benjaminglass1 marked this pull request as ready for review July 18, 2025 22:27
@benjaminglass1 benjaminglass1 added the module: build Build system issues label Jul 18, 2025
@benjaminglass1 benjaminglass1 requested a review from malfet July 18, 2025 22:27
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: 9e5fd2b
Pull Request resolved: #158686
[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Jul 21, 2025
ghstack-source-id: 6bd47a3
Pull Request resolved: #158686
Copy link
Contributor

@eellison eellison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable to me but maybe defer to @malfet

@benjaminglass1
Copy link
Collaborator Author

Having heard nothing, I'm going to merge this and revert if there are complaints.

[ghstack-poisoned]
benjaminglass1 added a commit that referenced this pull request Sep 9, 2025
ghstack-source-id: 3597f3f
Pull Request resolved: #158686
@benjaminglass1
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 9, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
@github-actions github-actions bot deleted the gh/benjaminglass1/95/head branch October 10, 2025 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: build Build system issues open source release notes: build release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants