Skip to content

Conversation

yangw-dev
Copy link
Contributor

@yangw-dev yangw-dev commented Jul 21, 2025

It seems the nightly.yml won't auto-generate txt file when it does not existed, so added the file with latest merged commit from vllm:

vllm commit

Error:
https://github.com/pytorch/pytorch/actions/runs/16405915719/job/46351847504

Signed-off-by: Yang Wang <elainewy@meta.com>
Copy link

pytorch-bot bot commented Jul 21, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/158754

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8d1494f with merge base 9894d43 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@yangw-dev yangw-dev requested a review from huydhn July 21, 2025 17:22
@yangw-dev yangw-dev marked this pull request as ready for review July 21, 2025 17:34
@yangw-dev yangw-dev requested a review from jeffdaily as a code owner July 21, 2025 17:34
@yangw-dev yangw-dev changed the title Add vllm.txt for pinned commit [vllm]Add vllm.txt for pinned commit Jul 21, 2025
@@ -0,0 +1 @@
29d1ffc5b4c763ef76aff9e3f617fa60dd292418
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be added to .github/ci_commit_pins instead because this is built after PyTorch, so we couldn't build this as part of Docker build workflow. But then, I think it depends on how you want to use this file later on as I remember you mention that we want to do the Docker image route eventually

Signed-off-by: Yang Wang <elainewy@meta.com>
Signed-off-by: Yang Wang <elainewy@meta.com>
@yangw-dev yangw-dev requested a review from a team as a code owner July 21, 2025 19:05
@yangw-dev
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jul 21, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

saienduri pushed a commit to saienduri/pytorch that referenced this pull request Jul 22, 2025
It seems the nightly.yml won't auto-generate txt file when it does not existed, so added the file with latest merged commit from vllm:

[vllm commit](https://github.com/vllm-project/vllm/commits/main)

Error:
https://github.com/pytorch/pytorch/actions/runs/16405915719/job/46351847504
Pull Request resolved: pytorch#158754
Approved by: https://github.com/huydhn
@github-actions github-actions bot deleted the addvllpinnedfile branch August 21, 2025 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants