Skip to content

[Dynamo][Hierarchical Compile] Refactor for tuple flattening #158810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Dynamo][Hierarchical Compile] Refactor for tuple flattening #158810

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e03f157
[Dynamo][Hierarchical Compile] Refactor for tuple flattening
mlazos Jul 22, 2025
314e504
Update on "[Dynamo][Hierarchical Compile] Refactor for tuple flattening"
mlazos Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 6 additions & 18 deletions torch/_dynamo/graph_deduplication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,11 @@ def _get_inds_with_external_users(region: Region, inds_unique: set[int]) -> None
inds_unique.add(ind)


def _copy_nodes_and_remap_inputs(
subgraph: torch.fx.Graph, region: Region
) -> list[OrderedSet[UsageIndex]]:
def _create_subgraph(
region: Region,
inds_with_external_users: list[int],
) -> tuple[torch.fx.Graph, list[OrderedSet[UsageIndex]]]:
subgraph: torch.fx.Graph = torch.fx.Graph()
external_input_to_usages = _get_external_inputs(region)
external_node_usages = list[OrderedSet[UsageIndex]]()
region_to_subgraph_node = {}
Expand All @@ -241,24 +243,10 @@ def map_arg(node: Node) -> Node:
subgraph_node = subgraph.node_copy(node, lambda old: map_arg(old))
region_to_subgraph_node[node] = subgraph_node

return external_node_usages


def _create_subgraph_outputs(
subgraph: torch.fx.Graph, inds_to_output: list[int]
) -> None:
node_list = [n for n in subgraph.nodes if n.op not in ("placeholder", "output")]
out_tup = tuple(node_list[ind] for ind in inds_to_output)
out_tup = tuple(node_list[ind] for ind in inds_with_external_users)
subgraph.output(out_tup)


def _create_subgraph(
region: Region,
inds_with_external_users: list[int],
) -> tuple[torch.fx.Graph, list[OrderedSet[UsageIndex]]]:
subgraph: torch.fx.Graph = torch.fx.Graph()
external_node_usages = _copy_nodes_and_remap_inputs(subgraph, region)
_create_subgraph_outputs(subgraph, inds_with_external_users)
return subgraph, external_node_usages


Expand Down
Loading