-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[while_loop] stop manually setting example inputs in dynamo #159063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159063
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (9 Unrelated Failures)As of commit 8326953 with merge base ee97dbf ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but was present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
I am interested in a bit of context here since I have been working with example_values a bit lately - why do we want to stop setting them for these HOPs? |
|
These hops have their fake implementation so the example values can be auto-inferred when running fake implementation in wrap_fake |
|
Starting merge as part of PR stack under #159065 |
1 similar comment
|
Starting merge as part of PR stack under #159065 |
Pull Request resolved: #159064 Approved by: https://github.com/zou3519 ghstack dependencies: #159063
Pull Request resolved: #159065 Approved by: https://github.com/zou3519 ghstack dependencies: #159063, #159064
Pull Request resolved: #159063 Approved by: https://github.com/zou3519
Pull Request resolved: #159064 Approved by: https://github.com/zou3519 ghstack dependencies: #159063
Pull Request resolved: #159065 Approved by: https://github.com/zou3519 ghstack dependencies: #159063, #159064
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela