[nativert] make per-node benchmark work with memory planning #159117
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159117
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 1ed54a7 with merge base ee84ba4 ( UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D78934104 |
dolpm
added a commit
to dolpm/pytorch
that referenced
this pull request
Jul 25, 2025
…#159117) Summary: this will use-after-free otherwise Test Plan: buck2 run //sigmoid/inference/test_cpu:prod_model_benchmark -- --pytorch_predictor_sigmoid_memory_layout_planning_enable=true --pytorch_predictor_sigmoid_memory_layout_planning_modules=local,local_request_only,user,object,mix,merge,remote_request_only,remote_other --load_lowered_merge=0 Rollback Plan: Differential Revision: D78934104
SherlockNoMad
approved these changes
Jul 25, 2025
…#159117) Summary: Pull Request resolved: pytorch#159117 this will use-after-free otherwise Test Plan: buck2 run //sigmoid/inference/test_cpu:prod_model_benchmark -- --pytorch_predictor_sigmoid_memory_layout_planning_enable=true --pytorch_predictor_sigmoid_memory_layout_planning_modules=local,local_request_only,user,object,mix,merge,remote_request_only,remote_other --load_lowered_merge=0 Rollback Plan: Reviewed By: SherlockNoMad Differential Revision: D78934104
|
This pull request was exported from Phabricator. Differential Revision: D78934104 |
|
This pull request was exported from Phabricator. Differential Revision: D78934104 |
|
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
yangw-dev
pushed a commit
that referenced
this pull request
Aug 1, 2025
Summary: this will use-after-free otherwise Rollback Plan: Differential Revision: D78934104 Pull Request resolved: #159117 Approved by: https://github.com/SherlockNoMad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: this will use-after-free otherwise
Rollback Plan:
Differential Revision: D78934104