[cutlass backend] skip stream k if shape is dynamic #159442
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D79229210](https://our.internmc.facebook.com/intern/diff/D79229210/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159442
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (6 Unrelated Failures)As of commit 6699691 with merge base b4619f0 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
henrylhtsang
added a commit
that referenced
this pull request
Jul 30, 2025
Differential Revision: [D79229210](https://our.internmc.facebook.com/intern/diff/D79229210/) ghstack-source-id: 299451983 Pull Request resolved: #159442
|
This pull request was exported from Phabricator. Differential Revision: D79229210 |
| self, | ||
| ): | ||
| """ | ||
| Test streamk with dynamic=False. Streamk should work. |
There was a problem hiding this comment.
maybe assert stream-k kernel ended up in the compiled program?
There was a problem hiding this comment.
maybe assert stream-k kernel ended up in the compiled program?
@ColinPeppler that should be guaranteed by the filtering?
There was a problem hiding this comment.
better to be explicit about it (if it's fairly easy to check)!
Differential Revision: [D79229210](https://our.internmc.facebook.com/intern/diff/D79229210/) cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
henrylhtsang
added a commit
that referenced
this pull request
Jul 30, 2025
Pull Request resolved: #159442 ghstack-source-id: 299575375 @exported-using-ghexport Differential Revision: [D79229210](https://our.internmc.facebook.com/intern/diff/D79229210/)
|
This pull request was exported from Phabricator. Differential Revision: D79229210 |
ColinPeppler
reviewed
Aug 1, 2025
Comment on lines
+923
to
+930
| # only use stream k for static shape | ||
| if op.tile_scheduler.name == "StreamK": | ||
| static_shape = PythonWrapperCodegen.statically_known_list_of_ints_or_none( | ||
| tuple(X.get_size()) + tuple(W.get_size()) | ||
| ) | ||
| if not static_shape: | ||
| return None | ||
|
|
There was a problem hiding this comment.
a log would be a nice-to-have here
ColinPeppler
approved these changes
Aug 1, 2025
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D79229210
Motivation is workspace size is hard to determine, and varies for different shape. What I observed is sometimes the shape got smaller, but the workspace can increase. So it is hard to upper bound it.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben