[Caffe2] Add float batch box cox SVE128 implementation #159778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

Nicoshev wants to merge 1 commit into pytorch:main from Nicoshev:export-D78994871

Contributor

Nicoshev commented Aug 4, 2025 •

edited by pytorch-bot bot

Loading

Introduce SVE128 SIMD batch box-cox computation.

We've seen about 65% throughput improvement.

Privacy Context Container: L1196524

This is a no-op from OSS point of view, therefore it could be landed without tests (see precedence set by #143627), but we should delete those at some point

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @jerryzh168 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

pytorch-bot bot commented Aug 4, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/159778

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6b223ae with merge base 01c3c89 ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

linux-foundation-easycla bot commented Aug 4, 2025 •

edited

Loading

The committers listed above are authorized under a signed CLA.

✅ login: Nicoshev / name: Nicolas De Carli (6b223ae)

pytorch-bot bot added ciflow/inductor module: cpu module: inductor release notes: sparse labels

Contributor

facebook-github-bot commented Aug 4, 2025

This pull request was exported from Phabricator. Differential Revision: D78994871

facebook-github-bot added the fb-exported label

Nicoshev requested review from IvanYashchuk, lezcano and nikitaved as code owners

August 4, 2025 18:02

Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev force-pushed the export-D78994871 branch from 213f53a to 4a145fa Compare

August 5, 2025 02:43

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

4a145fa

Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

c03188b

Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Nicoshev force-pushed the export-D78994871 branch from 4a145fa to c03188b Compare

August 5, 2025 02:47

Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev force-pushed the export-D78994871 branch from c03188b to 3f838b1 Compare

August 5, 2025 04:50

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

3f838b1

Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev force-pushed the export-D78994871 branch from 3f838b1 to 02a9710 Compare

August 5, 2025 04:57

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

02a9710

Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev force-pushed the export-D78994871 branch from 02a9710 to 03fb3ed Compare

August 5, 2025 15:36

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

03fb3ed

Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Contributor

facebook-github-bot commented Aug 5, 2025

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

45389c2

Summary:
Pull Request resolved: pytorch#159778

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Nicoshev force-pushed the export-D78994871 branch from 03fb3ed to 45389c2 Compare

August 5, 2025 15:50

Contributor

facebook-github-bot commented Aug 6, 2025

This pull request was exported from Phabricator. Differential Revision: D78994871

Nicoshev force-pushed the export-D78994871 branch from cd4e09a to 467f05d Compare

September 15, 2025 17:09

Contributor

facebook-github-bot commented Sep 15, 2025

@Nicoshev has exported this pull request. If you are a Meta employee, you can view the originating diff in D78994871.

Nicoshev requested a review from malfet

September 15, 2025 17:53

malfet requested changes

View reviewed changes

Contributor

malfet left a comment

Please used auto to avoid some hard to spot casting errors
Use C10_LIKELY/C10_UNLIKELY instead of __builtin_expect
Add new unittest or mention in PR which test validates this one

caffe2/perfkernels/batch_box_cox_Sve128.cc Outdated Show resolved Hide resolved

caffe2/perfkernels/batch_box_cox_Sve128.cc Show resolved Hide resolved

Nicoshev force-pushed the export-D78994871 branch from 467f05d to 4e93a0e Compare

September 15, 2025 19:00

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

4e93a0e

Summary:

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Contributor

facebook-github-bot commented Sep 15, 2025

@Nicoshev has exported this pull request. If you are a Meta employee, you can view the originating diff in D78994871.

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

c1d57a4

Summary:

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Nicoshev force-pushed the export-D78994871 branch from 4e93a0e to c1d57a4 Compare

September 15, 2025 19:08

Contributor

facebook-github-bot commented Sep 15, 2025

@Nicoshev has exported this pull request. If you are a Meta employee, you can view the originating diff in D78994871.

Nicoshev added a commit to Nicoshev/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

229c60c

Summary:

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Nicoshev force-pushed the export-D78994871 branch from c1d57a4 to 229c60c Compare

September 15, 2025 19:11

Contributor

facebook-github-bot commented Sep 15, 2025

@Nicoshev has exported this pull request. If you are a Meta employee, you can view the originating diff in D78994871.

Nicoshev requested a review from malfet

September 15, 2025 19:13

malfet approved these changes

View reviewed changes


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

6b223ae

Summary:

We are introducing SVE128 perfkernels

As first translation, we are implementing float32 batch box cox for SVE128

Test Plan:
Sigrid Predictor canary

Rollback Plan:

Differential Revision:
D78994871

Privacy Context Container: L1196524

Nicoshev force-pushed the export-D78994871 branch from 229c60c to 6b223ae Compare

September 15, 2025 20:33

Contributor

facebook-github-bot commented Sep 15, 2025

@Nicoshev has exported this pull request. If you are a Meta employee, you can view the originating diff in D78994871.

Contributor

facebook-github-bot commented Sep 16, 2025

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Sep 16, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot closed this in

2459da4

pytorchmergebot added Merged and removed merging labels

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

a89048c

Introduce SVE128 SIMD batch box-cox computation.

We've seen about 65% throughput improvement.

Privacy Context Container: L1196524

This is a no-op from OSS point of view, therefore it could be landed without tests (see precedence set by pytorch#143627), but we should delete those at some point

Pull Request resolved: pytorch#159778
Approved by: https://github.com/malfet

mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

eb7dfa7

Introduce SVE128 SIMD batch box-cox computation.

We've seen about 65% throughput improvement.

Privacy Context Container: L1196524

This is a no-op from OSS point of view, therefore it could be landed without tests (see precedence set by pytorch#143627), but we should delete those at some point

Pull Request resolved: pytorch#159778
Approved by: https://github.com/malfet

cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

82682cd

Introduce SVE128 SIMD batch box-cox computation.

We've seen about 65% throughput improvement.

Privacy Context Container: L1196524

This is a no-op from OSS point of view, therefore it could be landed without tests (see precedence set by pytorch#143627), but we should delete those at some point

Pull Request resolved: pytorch#159778
Approved by: https://github.com/malfet

dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request


          [Caffe2] Add float batch box cox SVE128 implementation (pytorch#159778)

99963e5

Introduce SVE128 SIMD batch box-cox computation.

We've seen about 65% throughput improvement.

Privacy Context Container: L1196524

This is a no-op from OSS point of view, therefore it could be landed without tests (see precedence set by pytorch#143627), but we should delete those at some point

Pull Request resolved: pytorch#159778
Approved by: https://github.com/malfet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk fb-exported Merged meta-exported module: cpu module: inductor release notes: sparse