Skip to content

Add stable Tensor get_device_index, use more stable DeviceIndex #160143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Add stable Tensor get_device_index, use more stable DeviceIndex #160143

wants to merge 3 commits into from

Conversation

janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Aug 7, 2025 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 7, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160143

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b4b96c1 with merge base 9903ca4 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

janeyx99 added a commit that referenced this pull request Aug 7, 2025
@janeyx99
Add stable Tensor get_device_index, use more stable DeviceIndex
ed03c31 
ghstack-source-id: ba2cb03
Pull Request resolved: #160143
janeyx99 added a commit that referenced this pull request Aug 7, 2025
@janeyx99
Add stable Tensor get_device_index, use more stable DeviceIndex
fe6448d 
ghstack-source-id: 7bc76e7
Pull Request resolved: #160143
mikaylagawarecki
mikaylagawarecki approved these changes Aug 8, 2025
View reviewed changes
Copy link
Contributor

@mikaylagawarecki mikaylagawarecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine -- curious question, do we really expect people to have more than 127 devices :O

janeyx99 added a commit that referenced this pull request Aug 12, 2025
@janeyx99
Add stable Tensor get_device_index, use more stable DeviceIndex
e4a39b8 
ghstack-source-id: 37c9869
Pull Request resolved: #160143
@janeyx99
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 12, 2025
@janeyx99 janeyx99 added release notes: build release notes category ciflow/trunk Trigger trunk jobs on your pull request and removed ciflow/trunk Trigger trunk jobs on your pull request labels Aug 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / cuda12.8-py3.10-gcc9-sm80 / build

Details for Dev Infra team Raised by workflow job

@janeyx99
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / cuda12.8-py3.10-gcc9-sm80 / build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

chuanhaozhuge pushed a commit that referenced this pull request Aug 14, 2025
@janeyx99 @chuanhaozhuge
Add stable Tensor get_device_index, use more stable DeviceIndex (#160143
cdd38b6 
)

Pull Request resolved: #160143
Approved by: https://github.com/mikaylagawarecki
chuanhaozhuge pushed a commit that referenced this pull request Aug 18, 2025
@janeyx99 @chuanhaozhuge
Add stable Tensor get_device_index, use more stable DeviceIndex (#160143
6019e08 
)

Pull Request resolved: #160143
Approved by: https://github.com/mikaylagawarecki
can-gaa-hou pushed a commit to can-gaa-hou/pytorch that referenced this pull request Aug 22, 2025
@janeyx99 @can-gaa-hou
Add stable Tensor get_device_index, use more stable DeviceIndex (pyto…
6afb75c 
…rch#160143)

Pull Request resolved: pytorch#160143
Approved by: https://github.com/mikaylagawarecki
@github-actions github-actions bot deleted the gh/janeyx99/297/head branch September 13, 2025 02:05
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@janeyx99 @markc-614
Add stable Tensor get_device_index, use more stable DeviceIndex (pyto…
0de6281 
…rch#160143)

Pull Request resolved: pytorch#160143
Approved by: https://github.com/mikaylagawarecki
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikaylagawarecki mikaylagawarecki mikaylagawarecki approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: build release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janeyx99 @pytorchmergebot @mikaylagawarecki