-
Notifications
You must be signed in to change notification settings - Fork 25.6k
CMake build: preserve PYTHONPATH #160144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake build: preserve PYTHONPATH #160144
Conversation
Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160144
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 9 PendingAs of commit fee0aab with merge base a53d14d ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but do you mind adding a test, otherwise it will regress next time someone will try to do the refactor
Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
To add the ciflow label This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows. |
@pytorchbot merge |
How would I do this? |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: windows-binary-wheel / wheel-py3_13t-xpu-build Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 1 checks: windows-binary-wheel / wheel-py3_13t-xpu-build Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_11-cuda12_8-full-test / test Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -f "Everything is green" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#160092 I'm very new to CMake, so let me know if there's a fancier way to do this. Pull Request resolved: pytorch#160144 Approved by: https://github.com/malfet Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
Fixes pytorch#160092 I'm very new to CMake, so let me know if there's a fancier way to do this. Pull Request resolved: pytorch#160144 Approved by: https://github.com/malfet Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
Fixes #160092
I'm very new to CMake, so let me know if there's a fancier way to do this.