Skip to content

Conversation

adamjstewart
Copy link
Contributor

Fixes #160092

I'm very new to CMake, so let me know if there's a fancier way to do this.

Signed-off-by: Adam J. Stewart <ajstewart426@gmail.com>
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Aug 7, 2025
Copy link

pytorch-bot bot commented Aug 7, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160144

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 9 Pending

As of commit fee0aab with merge base a53d14d (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but do you mind adding a test, otherwise it will regress next time someone will try to do the refactor

@malfet malfet added this to the 2.8.1 milestone Aug 7, 2025
@XuehaiPan XuehaiPan added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Aug 8, 2025
Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
@pytorch-bot pytorch-bot bot removed the ciflow/binaries Trigger all binary build and upload jobs on the PR label Aug 8, 2025
@XuehaiPan XuehaiPan added ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request labels Aug 8, 2025
Copy link

pytorch-bot bot commented Aug 8, 2025

To add the ciflow label ciflow/trunk please first approve the workflows that are awaiting approval (scroll to the bottom of this page).

This helps ensure we don't trigger CI on this PR until it is actually authorized to do so. Please ping one of the reviewers if you do not have access to approve and run workflows.

@pytorch-bot pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Aug 8, 2025
@XuehaiPan
Copy link
Collaborator

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 8, 2025
@adamjstewart
Copy link
Contributor Author

do you mind adding a test

How would I do this?

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: windows-binary-wheel / wheel-py3_13t-xpu-build

Details for Dev Infra team Raised by workflow job

@XuehaiPan
Copy link
Collaborator

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 1 checks: windows-binary-wheel / wheel-py3_13t-xpu-build

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_11-cuda12_8-full-test / test

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor

malfet commented Aug 8, 2025

@pytorchbot merge -f "Everything is green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@adamjstewart adamjstewart deleted the cmake/pythonpath branch August 8, 2025 16:31
hinriksnaer pushed a commit to hinriksnaer/pytorch that referenced this pull request Aug 8, 2025
Fixes pytorch#160092

I'm very new to CMake, so let me know if there's a fancier way to do this.
Pull Request resolved: pytorch#160144
Approved by: https://github.com/malfet

Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
Fixes pytorch#160092

I'm very new to CMake, so let me know if there's a fancier way to do this.
Pull Request resolved: pytorch#160144
Approved by: https://github.com/malfet

Co-authored-by: Xuehai Pan <XuehaiPan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/binaries Trigger all binary build and upload jobs on the PR ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyTorch 2.8: PYTHONPATH no longer respected when building from source?

5 participants