fix cpp builder to avoid missing-source compile error #160354

izaitsevfb · 2025-08-11T20:53:17Z

Summary:
the condition

if config.is_fbcode() and (not self._aot_mode or self._use_relative_path):
    sources = [os.path.basename(i) for i in sources]

unintentionally (?) stripped paths even when use_relative_path was False (as long as aot_mode was False), breaking local tests that rely on absolute temp-file paths.

Fixes internal issue:


FAILED (errors=1)

CppCompileError: C++ compile error

Command:
/mnt/gvfs/third-party2/llvm-fb/0f1f083aa5508772f3db24bf4f697bc118ba0958/17/platform010/72a2ff8/bin/clang-17 czyi3nhzin5b3mc3376vmfnlbjobvjcghbvv4tatuazs3syqubay.cpp -shared -fPIC -O3 -DNDEBUG -fno-trapping-math -funsafe-math-optimizations -ffinite-math-only -fno-signed-zeros -fno-math-errno -fno-finite-math-only -fno-unsafe-math-optimizations -ffp-contract=off -Wall -std=c++17 -Wno-unused-variable -Wno-unknown-pragmas -Werror=ignored-optimization-argument -g -o /re_tmp/tmpsp58ya2h/zy/test_symbol.so

Output:
clang-17: error: no such file or directory: 'czyi3nhzin5b3mc3376vmfnlbjobvjcghbvv4tatuazs3syqubay.cpp'
clang-17: error: no input files

Reviewed By: clee2000

Differential Revision: D80025417

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Summary: the condition ``` if config.is_fbcode() and (not self._aot_mode or self._use_relative_path): sources = [os.path.basename(i) for i in sources] ``` unintentionally (?) stripped paths even when use_relative_path was False (as long as aot_mode was False), breaking local tests that rely on absolute temp-file paths. Test Plan: ``` buck test 'fbcode//mode/opt' fbcode//caffe2/test/inductor:compile -- --exact 'caffe2/test/inductor:compile - test_inductor_generate_debug_symbol (caffe2.test.inductor.test_compile.TestStandaloneInductor)' ``` before: https://www.internalfb.com/intern/testinfra/testconsole/testrun/3096224990559147/ after: https://www.internalfb.com/intern/testinfra/testconsole/testrun/10696049217601708/ Rollback Plan: Reviewed By: clee2000 Differential Revision: D80025417

pytorch-bot · 2025-08-11T20:53:20Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160354

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki or our office hours

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 812cced with merge base b149c72 ():

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / linux-jammy-py3.9-clang12 / test (crossref, 2, 2, linux.2xlarge) (gh) (similar failure)
cpp/test_jit 1/1 failed!

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot · 2025-08-11T20:53:33Z

This pull request was exported from Phabricator. Differential Revision: D80025417

Copilot

Pull Request Overview

This PR fixes a logic error in the C++ builder that was incorrectly stripping absolute paths from source files, causing compilation failures in local tests. The issue was in a compound boolean condition that unintentionally applied path stripping when aot_mode was False, even when use_relative_path was also False.

Simplified the boolean logic to only use relative paths when explicitly requested
Added a clarifying comment explaining when relative paths should be used

Copilot · 2025-08-11T20:55:40Z

torch/_inductor/cpp_builder.py


-        if config.is_fbcode() and (not self._aot_mode or self._use_relative_path):
+        # Use relative paths only when requested (typically for remote builds)
+        if config.is_fbcode() and self._use_relative_path:


The fix correctly addresses the logic error, but consider the potential impact on existing code that might have been relying on the previous behavior when aot_mode is False. Ensure that all callers that previously worked with aot_mode=False and use_relative_path=False still function correctly with absolute paths.

Suggested change

if config.is_fbcode() and self._use_relative_path:

if self._use_relative_path:

benjaminglass1 · 2025-08-12T14:07:06Z

torch/_inductor/cpp_builder.py


-        if config.is_fbcode() and (not self._aot_mode or self._use_relative_path):
+        # Use relative paths only when requested (typically for remote builds)
+        if config.is_fbcode() and self._use_relative_path:


@izaitsevfb This conditional has always confused me; it existed before I touched this code. Since this passes the CI tests, you have my approval on the change!

facebook-github-bot · 2025-08-12T16:38:53Z

@pytorchbot merge -i

(Initiating merge automatically since Phabricator Diff has merged, merging with -i because oss signals were bypassed internally)

pytorchmergebot · 2025-08-12T16:43:43Z

Merge failed

Reason: Approvers from one of the following sets are needed:

superuser (pytorch/metamates)
Core Reviewers (mruberry, lezcano, Skylion007, ngimel, peterbell10, ...)
Core Maintainers (soumith, gchanan, ezyang, dzhulgakov, malfet, ...)

Details for Dev Infra team

Raised by workflow job

Failing merge rule: Core Maintainers

clee2000 · 2025-08-12T21:27:53Z

@pytorchbot merge -f "landed internally"

pytorchmergebot · 2025-08-12T21:35:55Z

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Summary: the condition ``` if config.is_fbcode() and (not self._aot_mode or self._use_relative_path): sources = [os.path.basename(i) for i in sources] ``` unintentionally (?) stripped paths even when use_relative_path was False (as long as aot_mode was False), breaking local tests that rely on absolute temp-file paths. Fixes internal issue: ``` FAILED (errors=1) CppCompileError: C++ compile error Command: /mnt/gvfs/third-party2/llvm-fb/0f1f083aa5508772f3db24bf4f697bc118ba0958/17/platform010/72a2ff8/bin/clang-17 czyi3nhzin5b3mc3376vmfnlbjobvjcghbvv4tatuazs3syqubay.cpp -shared -fPIC -O3 -DNDEBUG -fno-trapping-math -funsafe-math-optimizations -ffinite-math-only -fno-signed-zeros -fno-math-errno -fno-finite-math-only -fno-unsafe-math-optimizations -ffp-contract=off -Wall -std=c++17 -Wno-unused-variable -Wno-unknown-pragmas -Werror=ignored-optimization-argument -g -o /re_tmp/tmpsp58ya2h/zy/test_symbol.so Output: clang-17: error: no such file or directory: 'czyi3nhzin5b3mc3376vmfnlbjobvjcghbvv4tatuazs3syqubay.cpp' clang-17: error: no input files ``` Reviewed By: clee2000 Differential Revision: D80025417 Pull Request resolved: #160354 Approved by: https://github.com/benjaminglass1, https://github.com/clee2000

Summary: the condition ``` if config.is_fbcode() and (not self._aot_mode or self._use_relative_path): sources = [os.path.basename(i) for i in sources] ``` unintentionally (?) stripped paths even when use_relative_path was False (as long as aot_mode was False), breaking local tests that rely on absolute temp-file paths. Fixes internal issue: ``` FAILED (errors=1) CppCompileError: C++ compile error Command: /mnt/gvfs/third-party2/llvm-fb/0f1f083aa5508772f3db24bf4f697bc118ba0958/17/platform010/72a2ff8/bin/clang-17 czyi3nhzin5b3mc3376vmfnlbjobvjcghbvv4tatuazs3syqubay.cpp -shared -fPIC -O3 -DNDEBUG -fno-trapping-math -funsafe-math-optimizations -ffinite-math-only -fno-signed-zeros -fno-math-errno -fno-finite-math-only -fno-unsafe-math-optimizations -ffp-contract=off -Wall -std=c++17 -Wno-unused-variable -Wno-unknown-pragmas -Werror=ignored-optimization-argument -g -o /re_tmp/tmpsp58ya2h/zy/test_symbol.so Output: clang-17: error: no such file or directory: 'czyi3nhzin5b3mc3376vmfnlbjobvjcghbvv4tatuazs3syqubay.cpp' clang-17: error: no input files ``` Reviewed By: clee2000 Differential Revision: D80025417 Pull Request resolved: pytorch#160354 Approved by: https://github.com/benjaminglass1, https://github.com/clee2000

pytorch-bot bot added ciflow/inductor module: inductor labels Aug 11, 2025

facebook-github-bot added the fb-exported label Aug 11, 2025

izaitsevfb requested review from benjaminglass1, Copilot and desertfire August 11, 2025 20:55

Copilot AI reviewed Aug 11, 2025

View reviewed changes

benjaminglass1 reviewed Aug 12, 2025

View reviewed changes

benjaminglass1 approved these changes Aug 12, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 12, 2025

pytorchmergebot added the merging label Aug 12, 2025

pytorchmergebot removed the merging label Aug 12, 2025

clee2000 approved these changes Aug 12, 2025

View reviewed changes

pytorchmergebot added the merging label Aug 12, 2025

pytorchmergebot added the Merged label Aug 12, 2025

pytorchmergebot closed this in f8f0414 Aug 12, 2025

pytorchmergebot removed the merging label Aug 12, 2025

github-actions bot deleted the export-D80025417 branch September 12, 2025 02:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix cpp builder to avoid missing-source compile error #160354

fix cpp builder to avoid missing-source compile error #160354

Uh oh!

izaitsevfb commented Aug 11, 2025 •

edited

Loading

Uh oh!

pytorch-bot bot commented Aug 11, 2025 •

edited

Loading

Uh oh!

facebook-github-bot commented Aug 11, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Aug 11, 2025

Uh oh!

benjaminglass1 Aug 12, 2025

Uh oh!

facebook-github-bot commented Aug 12, 2025

Uh oh!

pytorchmergebot commented Aug 12, 2025

Uh oh!

clee2000 commented Aug 12, 2025

Uh oh!

pytorchmergebot commented Aug 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

	if config.is_fbcode() and self._use_relative_path:
	if self._use_relative_path:

fix cpp builder to avoid missing-source compile error #160354

fix cpp builder to avoid missing-source compile error #160354

Uh oh!

Conversation

izaitsevfb commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Aug 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160354

✅ You can merge normally! (1 Unrelated Failure)

Uh oh!

facebook-github-bot commented Aug 11, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

Uh oh!

benjaminglass1 Aug 12, 2025

Choose a reason for hiding this comment

Uh oh!

facebook-github-bot commented Aug 12, 2025

Uh oh!

pytorchmergebot commented Aug 12, 2025

Merge failed

Uh oh!

clee2000 commented Aug 12, 2025

Uh oh!

pytorchmergebot commented Aug 12, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

izaitsevfb commented Aug 11, 2025 •

edited

Loading

pytorch-bot bot commented Aug 11, 2025 •

edited

Loading