Skip to content

Conversation

@skarjala
Copy link
Contributor

@skarjala skarjala commented Aug 12, 2025

Summary:

  • Emit a structured trace per compiled graph execution to reconstruct execution order in TLParse.
  • Adds debug.log_graph_execution(name) called from CompiledFxGraph.__call__, producing an artifact named inductor_graph_execution with payload {"graph": "graph_"}.

Testing:

  • Add inline test to verify structure and output

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Aug 12, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160448

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 New Failures, 1 Unrelated Failure

As of commit a60a83a with merge base 74124d1 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

skarjala added a commit that referenced this pull request Aug 12, 2025
ghstack-source-id: b7d22f3
Pull-Request: #160448
@skarjala skarjala changed the title execution order of graphs [inductor] structured-log graph execution order + test Aug 12, 2025
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 12, 2025
ghstack-source-id: ca1eee4
Pull-Request: #160448
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 13, 2025
ghstack-source-id: bb29518
Pull-Request: #160448
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 15, 2025
ghstack-source-id: 0291538
Pull-Request: #160448
skarjala added a commit that referenced this pull request Aug 15, 2025
ghstack-source-id: 0291538
Pull-Request: #160448
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 15, 2025
ghstack-source-id: cef3984
Pull-Request: #160448

fix cuda issue
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 15, 2025
ghstack-source-id: 44b73b9
Pull-Request: #160448

fix cuda issue
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 15, 2025
ghstack-source-id: 1ed24c9
Pull-Request: #160448

fix cuda issue

fix has cuda
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 15, 2025
ghstack-source-id: 0a01fcb
Pull-Request: #160448

fix cuda issue

fix has cuda
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 15, 2025
ghstack-source-id: 560cb9e
Pull-Request: #160448

fix cuda issue

fix has cuda
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 15, 2025
ghstack-source-id: 221c265
Pull-Request: #160448

fix cuda issue

fix has cuda
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 17, 2025
ghstack-source-id: c4282fc
Pull-Request: #160448

fix cuda issue

fix has cuda
@skarjala skarjala requested review from xmfan and yushangdi August 18, 2025 16:50
@atalman
Copy link
Contributor

atalman commented Aug 26, 2025

@pytorchmergebot revert -c ghfirst -m "internal failure please see associated diff"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Aug 26, 2025
…)"

This reverts commit 995397d.

Reverted #160448 on behalf of https://github.com/atalman due to internal failure please see associated diff ([comment](#160448 (comment)))
@pytorchmergebot
Copy link
Collaborator

@skarjala your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Aug 26, 2025
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 26, 2025
ghstack-source-id: cce5cc3
Pull-Request: #160448

fix cuda issue

fix has cuda

fix execution order logging

fix pr feedback

fix pr feedback

fix cache issue

fix test

fix errors

fix tests

fix expect test

fix test

add tlparse decorator
skarjala added a commit that referenced this pull request Aug 26, 2025
ghstack-source-id: cce5cc3
Pull-Request: #160448

fix cuda issue

fix has cuda

fix execution order logging

fix pr feedback

fix pr feedback

fix cache issue

fix test

fix errors

fix tests

fix expect test

fix test

add tlparse decorator
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 26, 2025
ghstack-source-id: cfb5ae1
Pull-Request: #160448

fix cuda issue

fix has cuda

fix execution order logging

fix pr feedback

fix pr feedback

fix cache issue

fix test

fix errors

fix tests

fix expect test

fix test

add tlparse decorator

submodules
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 26, 2025
ghstack-source-id: cce5cc3
Pull-Request: #160448

fix cuda issue

fix has cuda

fix execution order logging

fix pr feedback

fix pr feedback

fix cache issue

fix test

fix errors

fix tests

fix expect test

fix test

add tlparse decorator

submodules

Revert accidental submodule updates
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 26, 2025
ghstack-source-id: 65654c1
Pull-Request: #160448

fix cuda issue

fix has cuda

fix execution order logging

fix pr feedback

fix pr feedback

fix cache issue

fix test

fix errors

fix tests

fix expect test

fix test

add tlparse decorator

submodules

Revert accidental submodule updates
[ghstack-poisoned]
skarjala added a commit that referenced this pull request Aug 26, 2025
ghstack-source-id: fd44dc3
Pull-Request: #160448

fix cuda issue

fix has cuda

fix execution order logging

fix pr feedback

fix pr feedback

fix cache issue

fix test

fix errors

fix tests

fix expect test

fix test

add tlparse decorator

submodules

Revert accidental submodule updates

fix cuda test
@skarjala
Copy link
Contributor Author

@pytorchbot merge -i

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 3 checks: trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 3, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-cuda12.8-py3.10-gcc11 / test (default, 4, 5, lf.linux.g6.4xlarge.experimental.nvidia.gpu), trunk / linux-jammy-rocm-py3.10 / test (default, 1, 2, linux.rocm.gpu.gfx942.1)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
Summary:

- Emit a structured trace per compiled graph execution to reconstruct execution order in TLParse.
- Adds debug.log_graph_execution(name) called from `CompiledFxGraph.__call__`, producing an artifact named inductor_graph_execution with payload {"graph": "graph_<id>"}.

Testing:
- Add inline test to verify structure and output

Pull Request resolved: pytorch#160448
Approved by: https://github.com/xmfan
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
…ch#160448)"

This reverts commit 995397d.

Reverted pytorch#160448 on behalf of https://github.com/atalman due to internal failure please see associated diff ([comment](pytorch#160448 (comment)))
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
Summary:

- Emit a structured trace per compiled graph execution to reconstruct execution order in TLParse.
- Adds debug.log_graph_execution(name) called from `CompiledFxGraph.__call__`, producing an artifact named inductor_graph_execution with payload {"graph": "graph_<id>"}.

Testing:
- Add inline test to verify structure and output

Pull Request resolved: pytorch#160448
Approved by: https://github.com/xmfan
@github-actions github-actions bot deleted the gh/skarjala/19/head branch September 27, 2025 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants