-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Change IR node's stack trace to be computed lazily #160487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/160487
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8406ec9 with merge base 7d87e35 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This pull request was exported from Phabricator. Differential Revision: D80137870 |
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Differential Revision: D80137870
7142100
to
b1dc4a3
Compare
This pull request was exported from Phabricator. Differential Revision: D80137870 |
b1dc4a3
to
93bc553
Compare
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Differential Revision: D80137870
This pull request was exported from Phabricator. Differential Revision: D80137870 |
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Differential Revision: D80137870
93bc553
to
e588ff5
Compare
This pull request was exported from Phabricator. Differential Revision: D80137870 |
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Differential Revision: D80137870
e588ff5
to
8406ec9
Compare
This pull request was exported from Phabricator. Differential Revision: D80137870 |
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Reviewed By: angelayi Differential Revision: D80137870
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Reviewed By: angelayi Differential Revision: D80137870
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Reviewed By: angelayi Differential Revision: D80137870
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Reviewed By: angelayi Differential Revision: D80137870
@pytorchbot merge (Initiating merge automatically since Phabricator Diff has merged) |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Differential Revision: D80137870 Pull Request resolved: #160487 Approved by: https://github.com/angelayi
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Differential Revision: D80137870 Pull Request resolved: #160487 Approved by: https://github.com/angelayi
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Differential Revision: D80137870 Pull Request resolved: pytorch#160487 Approved by: https://github.com/angelayi
Summary: When an IR node is an inherited class, post_init is called once for each super().__init__() call. To avoid duplicated calls, we make stack trace computation happen lazily. Test Plan: CI Rollback Plan: Differential Revision: D80137870 Pull Request resolved: pytorch#160487 Approved by: https://github.com/angelayi
Summary: When an IR node is an inherited class, post_init is called once for each super().init() call. To avoid duplicated calls, we make stack trace computation happen lazily.
Test Plan:
CI
Rollback Plan:
Differential Revision: D80137870
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben