shape guards #161178
Closed
shape guards #161178
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avikchaudhuri
requested review from
SherlockNoMad,
angelayi,
bobrenjc93,
laithsakka,
tugsbayasgalan,
ydwu4 and
zhxchen17
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161178
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bbf4196 with merge base a92773e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Aug 26, 2025
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Differential Revision: D80713603
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
cdc76c4 to
a422664
Compare
pytorch-bot
bot
added
oncall: distributed
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
a422664 to
cd1f3fa
Compare
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Aug 27, 2025
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Differential Revision: D80713603
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Aug 27, 2025
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Differential Revision: D80713603
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
cd1f3fa to
185a89b
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
185a89b to
65c92b0
Compare
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Aug 27, 2025
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Differential Revision: D80713603
avikchaudhuri
added
the
suppress-bc-linter
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
28dc963 to
90d08f3
Compare
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Sep 6, 2025
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Reviewed By: tugsbayasgalan Differential Revision: D80713603
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
90d08f3 to
6977dbe
Compare
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Sep 7, 2025
Summary: This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Reviewed By: tugsbayasgalan Differential Revision: D80713603
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Sep 7, 2025
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Reviewed By: tugsbayasgalan Differential Revision: D80713603
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
6977dbe to
43121fa
Compare
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Sep 7, 2025
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Reviewed By: tugsbayasgalan Differential Revision: D80713603
avikchaudhuri
force-pushed
the
export-D80713603
branch
2 times, most recently
from
16b9872 to
49b65ca
Compare
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Sep 8, 2025
Summary: This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Reviewed By: tugsbayasgalan Differential Revision: D80713603
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
added a commit
to avikchaudhuri/pytorch
that referenced
this pull request
Sep 8, 2025
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Reviewed By: tugsbayasgalan Differential Revision: D80713603
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
49b65ca to
0777338
Compare
Summary: Pull Request resolved: pytorch#161178 This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Reviewed By: tugsbayasgalan Differential Revision: D80713603
|
This pull request was exported from Phabricator. Differential Revision: D80713603 |
avikchaudhuri
force-pushed
the
export-D80713603
branch
from
0777338 to
bbf4196
Compare
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
Summary: This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Differential Revision: D80713603 Pull Request resolved: pytorch#161178 Approved by: https://github.com/tugsbayasgalan
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
Summary: This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Differential Revision: D80713603 Pull Request resolved: pytorch#161178 Approved by: https://github.com/tugsbayasgalan
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
Summary: This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Differential Revision: D80713603 Pull Request resolved: pytorch#161178 Approved by: https://github.com/tugsbayasgalan
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
Summary: This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program. Test Plan: updated several tests Rollback Plan: Differential Revision: D80713603 Pull Request resolved: pytorch#161178 Approved by: https://github.com/tugsbayasgalan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: This PR introduces shape guards to export. Previously only value ranges, equalities, and specializations would be tracked for symbolic expressions, and we had a forward hook to check them. Instead now we create a function to check shape guards and call it in the exported program.
Test Plan:
updated several tests
Rollback Plan:
Differential Revision: D80713603
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @ezyang @msaroufim @SherlockNoMad @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela