[inductor] fix march=native pass to Windows CC. #161264
Conversation
xuhancn
added
module: windows
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161264
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8e255d2 with merge base 595987d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
||
| if config.aot_inductor.enable_lto and _is_clang(cpp_compiler): | ||
| cflags.append("flto=thin") | ||
| if _IS_WINDOWS: |
There was a problem hiding this comment.
could we simplify it to be, "if _IS_WINDOWS or sys.platform == "darwin", pass else ...."?
There was a problem hiding this comment.
could we simplify it to be, "if _IS_WINDOWS or sys.platform == "darwin", pass else ...."?
Your suggestion may break fb_code. I wrote this code with a lot failed on fb_code, so I prefered current code.
There was a problem hiding this comment.
Windows is totally different to UNIX like OSs. Current code is also make sense.
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
fix march=native pass to Windows CC. <img width="593" height="218" alt="image" src="https://github.com/user-attachments/assets/1caedffa-d9be-43d9-9ce2-590c055980cd" /> Pull Request resolved: pytorch#161264 Approved by: https://github.com/angelayi
4 participants
fix march=native pass to Windows CC.
cc @peterjc123 @mszhanyi @skyline75489 @nbcsm @iremyux @Blackhex @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben