Skip to content

[MPS] Fix index_copy for strided indices #161333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[MPS] Fix index_copy for strided indices #161333

wants to merge 1 commit into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Aug 23, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

By passing strides to strided variant of the tensor

Fixes #160993

@malfet
Update
b73f28e 
[ghstack-poisoned]
@malfet malfet requested a review from kulinseth as a code owner August 23, 2025 01:05
@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161333

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b73f28e with merge base cb57953 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Aug 23, 2025
malfet added a commit that referenced this pull request Aug 23, 2025
@malfet
[MPS] Fix index_copy for strided indices
0dcb005 
By passing strides to strided variant of the tensor

Fixes #160993

ghstack-source-id: 08a020c
Pull Request resolved: #161333
@malfet malfet added ciflow/trunk Trigger trunk jobs on your pull request topic: bug fixes topic category labels Aug 23, 2025
@malfet malfet requested a review from dcci August 23, 2025 01:06
huydhn
huydhn approved these changes Aug 23, 2025
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (pending CI)!

@malfet
Copy link
Contributor Author

malfet commented Aug 23, 2025

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@malfet @markc-614
[MPS] Fix index_copy for strided indices (pytorch#161333)
0c7f33d 
By passing strides to strided variant of the tensor

Fixes pytorch#160993
Pull Request resolved: pytorch#161333
Approved by: https://github.com/huydhn, https://github.com/wdvr
ghstack dependencies: pytorch#161206, pytorch#161267
@github-actions github-actions bot deleted the gh/malfet/500/head branch September 23, 2025 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@wdvr wdvr wdvr approved these changes

@kulinseth kulinseth Awaiting requested review from kulinseth

@dcci dcci Awaiting requested review from dcci

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: mps Release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @huydhn @wdvr