-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Fix LBFGS
wolfe max iteration
#161488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix LBFGS
wolfe max iteration
#161488
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161488
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b04dd84 with merge base 9009c4d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SGTM
@pytorchbot rebase -b main |
@pytorchbot started a rebase job onto refs/remotes/origin/main. Check the current status here |
Successfully rebased |
7716f0c
to
b04dd84
Compare
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#91581 , based on pytorch#135026 ## Test Result ```bash pytest test/test_optim.py ......... ========================== 1473 passed, 242 skipped in 2412.49s (0:40:12) =========================== ``` Pull Request resolved: pytorch#161488 Approved by: https://github.com/albanD
Fixes pytorch#91581 , based on pytorch#135026 ## Test Result ```bash pytest test/test_optim.py ......... ========================== 1473 passed, 242 skipped in 2412.49s (0:40:12) =========================== ``` Pull Request resolved: pytorch#161488 Approved by: https://github.com/albanD
Fixes pytorch#91581 , based on pytorch#135026 ## Test Result ```bash pytest test/test_optim.py ......... ========================== 1473 passed, 242 skipped in 2412.49s (0:40:12) =========================== ``` Pull Request resolved: pytorch#161488 Approved by: https://github.com/albanD
Fixes pytorch#91581 , based on pytorch#135026 ## Test Result ```bash pytest test/test_optim.py ......... ========================== 1473 passed, 242 skipped in 2412.49s (0:40:12) =========================== ``` Pull Request resolved: pytorch#161488 Approved by: https://github.com/albanD
Fixes #91581 , based on #135026
Test Result
pytest test/test_optim.py ......... ========================== 1473 passed, 242 skipped in 2412.49s (0:40:12) ===========================