Skip to content

Save a little bit of work in constant pooling by not moving nodes that will get deleted. #16161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Save a little bit of work in constant pooling by not moving nodes that will get deleted. #16161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions torch/csrc/jit/passes/constant_pooling.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,20 @@ void ConstantPooling(
continue;
}

auto first_node = node->owningGraph()->block()->nodes().front();
if (node != first_node)
node->moveBefore(first_node);

// Check whether the same constant already exists.
auto subit = constants.insert(node);
if (!subit.second) {
// constant exists, replace the uses of node, and destroy it.
auto existing = *subit.first;
node->replaceAllUsesWith(existing);
node->destroy();
continue;
}

// Move the constant definition to the beginning of the graph.
auto first_node = node->owningGraph()->block()->nodes().front();
if (node != first_node)
node->moveBefore(first_node);
}
}

Expand Down