Skip to content

Revert "Back out "Deprecate overleap functions in CUDAAllocatorConfig, use AcceleratorAllocatorConfig instead (#156165)" (#160999)" #161625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Revert "Back out "Deprecate overleap functions in CUDAAllocatorConfig, use AcceleratorAllocatorConfig instead (#156165)" (#160999)" #161625

wants to merge 2 commits into from

Conversation

@guangyey
Copy link
Collaborator

@guangyey guangyey commented Aug 27, 2025 •
edited
Loading

@pytorch-bot
Copy link

pytorch-bot bot commented Aug 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161625

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 8c3759d with merge base 55e6ea1 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the ci-no-td Do not run TD on this PR label Aug 27, 2025
This was referenced Aug 27, 2025
Closed
Closed
Closed
@guangyey guangyey added the topic: not user facing topic category label Aug 27, 2025
@guangyey guangyey requested a review from atalman August 27, 2025 17:30
@atalman
Copy link
Contributor

atalman commented Aug 27, 2025

@pytorchmergebot merge -f "lint is green and all required tests are passing"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Aug 27, 2025
@guangyey @pytorchmergebot
Revert "Generalize torch._C._set_allocator_settings to be generic (#1…
c03d8d4 
…56175)" (#161626)

This reverts commit 908c5cc.

Pull Request resolved: #161626
Approved by: https://github.com/atalman
ghstack dependencies: #161625
pytorchmergebot pushed a commit that referenced this pull request Aug 27, 2025
@guangyey @pytorchmergebot
Revert "Deprecate overleap functions in CUDAAllocatorConfig, use Acce…
b7b9fb9 
…leratorAllocatorConfig instead (#156165)" (#161627)

This reverts commit c114585.
Pull Request resolved: #161627
Approved by: https://github.com/atalman
ghstack dependencies: #161625, #161626
pytorchmergebot pushed a commit that referenced this pull request Aug 27, 2025
@guangyey @pytorchmergebot
Revert "Refactor CUDAAllocatorConfig to reuse AcceleratorAllocatorCon…
b9c6aa1 
…fig (#150312)" (#161628)

This reverts commit ae1a706.
Pull Request resolved: #161628
Approved by: https://github.com/atalman
ghstack dependencies: #161625, #161626, #161627
@guangyey
Update
4809460 
[ghstack-poisoned]
@guangyey
Update
8c3759d 
[ghstack-poisoned]
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@guangyey @markc-614
Revert "Back out "Deprecate overleap functions in CUDAAllocatorConfig…
d17a769 
…, use AcceleratorAllocatorConfig instead (pytorch#156165)" (pytorch#160999)" (pytorch#161625)

This reverts commit a818fa7.
Pull Request resolved: pytorch#161625
Approved by: https://github.com/atalman
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@guangyey @markc-614
Revert "Generalize torch._C._set_allocator_settings to be generic (py…
79f9b52 
…torch#156175)" (pytorch#161626)

This reverts commit 908c5cc.

Pull Request resolved: pytorch#161626
Approved by: https://github.com/atalman
ghstack dependencies: pytorch#161625
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@guangyey @markc-614
Revert "Deprecate overleap functions in CUDAAllocatorConfig, use Acce…
6ea68b8 
…leratorAllocatorConfig instead (pytorch#156165)" (pytorch#161627)

This reverts commit c114585.
Pull Request resolved: pytorch#161627
Approved by: https://github.com/atalman
ghstack dependencies: pytorch#161625, pytorch#161626
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@guangyey @markc-614
Revert "Refactor CUDAAllocatorConfig to reuse AcceleratorAllocatorCon…
e93368e 
…fig (pytorch#150312)" (pytorch#161628)

This reverts commit ae1a706.
Pull Request resolved: pytorch#161628
Approved by: https://github.com/atalman
ghstack dependencies: pytorch#161625, pytorch#161626, pytorch#161627
@github-actions github-actions bot deleted the gh/guangyey/196/head branch September 27, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@atalman atalman atalman approved these changes

@eqy eqy Awaiting requested review from eqy

@syed-ahmed syed-ahmed Awaiting requested review from syed-ahmed

@EikanWang EikanWang Awaiting requested review from EikanWang

@gujinghui gujinghui Awaiting requested review from gujinghui

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR Merged open source topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@guangyey @atalman @pytorchmergebot @pytorchbot