Skip to content

Select Algorithm clear feedback savers #161654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Select Algorithm clear feedback savers #161654

wants to merge 2 commits into from

Conversation

exclamaforte
Copy link
Contributor

@exclamaforte exclamaforte commented Aug 27, 2025 •
edited
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Aug 27, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161654

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 19b60d1 with merge base 443452c (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@exclamaforte exclamaforte added the topic: not user facing topic category label Aug 27, 2025
@exclamaforte exclamaforte requested a review from masnesral August 27, 2025 21:45
@exclamaforte exclamaforte changed the title clear feedback saver Select Algorithm clear feedback savers Aug 27, 2025
@facebook-github-bot
Copy link
Contributor

@exclamaforte has imported this pull request. If you are a Meta employee, you can view this in D81171481.

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Aug 27, 2025
@exclamaforte
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

Failing merge rule: Core Maintainers

@exclamaforte
Copy link
Contributor Author

@pytorchbot rebase

@exclamaforte
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased exclamaforte/clear-feedback-savers onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout exclamaforte/clear-feedback-savers && git pull --rebase)

@pytorchmergebot pytorchmergebot force-pushed the exclamaforte/clear-feedback-savers branch from 08cfd7b to 19b60d1 Compare August 28, 2025 00:38
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 1 jobs have failed, first few of them are: Meta Internal-Only Changes Check

Details for Dev Infra team Raised by workflow job

@facebook-github-bot
Copy link
Contributor

@exclamaforte has imported this pull request. If you are a Meta employee, you can view this in D81171481.

@exclamaforte
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
@exclamaforte @markc-614
Select Algorithm clear feedback savers (pytorch#161654)
3aae199 
Add `clear_feedback_savers` and tests for the feedback functionality.

Pull Request resolved: pytorch#161654
Approved by: https://github.com/masnesral
@github-actions github-actions bot deleted the exclamaforte/clear-feedback-savers branch September 28, 2025 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masnesral masnesral masnesral approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: inductor topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@exclamaforte @facebook-github-bot @pytorchmergebot @masnesral