[SymmMem] Isolate set_device tests to avoid hang #161668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161668
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 822bec9 with merge base 763053d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/h100-symm-mem
oncall: distributed
fegin
approved these changes
Aug 28, 2025
fegin
added a commit
that referenced
this pull request
Aug 28, 2025
test_empty_strided_p2p_persistent allocates persistent symm memory tensors. However, it uses the same alloc_id for different tests, which could cause troubles if these tests are ran under the same process. This PR fixes the issue by using a different alloc_id for different test. #161668 should also fix the issue but we can land this PR for a safer test. ghstack-source-id: 72f67de Pull-Request-resolved: #161677
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
fegin
added a commit
that referenced
this pull request
Aug 28, 2025
test_empty_strided_p2p_persistent allocates persistent symm memory tensors. However, it uses the same alloc_id for different tests, which could cause troubles if these tests are ran under the same process. This PR fixes the issue by using a different alloc_id for different test. #161668 should also fix the issue but we can land this PR for a safer test. ghstack-source-id: 0e89aff Pull-Request-resolved: #161677
fegin
added a commit
that referenced
this pull request
Aug 28, 2025
test_empty_strided_p2p_persistent allocates persistent symm memory tensors. However, it uses the same alloc_id for different tests, which could cause troubles if these tests are ran under the same process. This PR fixes the issue by using a different alloc_id for different test. #161668 should also fix the issue but we can land this PR for a safer test. ghstack-source-id: fa91e94 Pull-Request-resolved: #161677
pytorchmergebot
pushed a commit
that referenced
this pull request
Aug 29, 2025
test_empty_strided_p2p_persistent allocates persistent symm memory tensors. However, it uses the same alloc_id for different tests, which could cause troubles if these tests are ran under the same process. This PR fixes the issue by using a different alloc_id for different test. #161668 should also fix the issue but we can land this PR for a safer test. Pull Request resolved: #161677 Approved by: https://github.com/kwen2501 ghstack dependencies: #161676
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
`test_symmetric_memory.py` hangs like this: ``` SymmetricMemoryTest::test_empty_strided_p2p_persistent_set_device_False PASSED [5.6364s] SymmetricMemoryTest::test_empty_strided_p2p_persistent_set_device_True ... ``` This set of tests parameterizes whether user sets the device before calling `symm_mem.emtpy`. However, such parametrization does not work well with `MultiProcContinuousTest` because the set device will "contaminate" the next test function. Solution is to move the "set device" tests to a separate test suite using the traditional `MultiProcessTestCase`, which would respawn processes every time. Hang is gone now. Pull Request resolved: pytorch#161668 Approved by: https://github.com/fegin
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
test_empty_strided_p2p_persistent allocates persistent symm memory tensors. However, it uses the same alloc_id for different tests, which could cause troubles if these tests are ran under the same process. This PR fixes the issue by using a different alloc_id for different test. pytorch#161668 should also fix the issue but we can land this PR for a safer test. Pull Request resolved: pytorch#161677 Approved by: https://github.com/kwen2501 ghstack dependencies: pytorch#161676
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
test_symmetric_memory.pyhangs like this:This set of tests parameterizes whether user sets the device before calling
symm_mem.emtpy.However, such parametrization does not work well with
MultiProcContinuousTestbecause the set device will "contaminate" the next test function.Solution is to move the "set device" tests to a separate test suite using the traditional
MultiProcessTestCase, which would respawn processes every time.Hang is gone now.
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta