[dynamo] Graph break on on user-defined class in compiled region #161670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161670
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7b22c90 with merge base 86d34a4 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
rtimpe
commented
Aug 28, 2025
There was a problem hiding this comment.
This test (test_small_stability, which was deleted) was already passing before this PR. I'm not sure why
rtimpe
commented
Aug 29, 2025
test/test_fx.py
Outdated
| print(x) | ||
|
|
||
|
|
||
| @skipIfTorchDynamo("Not suitable for dynamo") |
There was a problem hiding this comment.
Some of these are failing during setup, but many define custom classes, so I think it's just easier to skip them all. If there's a desire to run these tests under dynamo, I can look at them more carefully
There was a problem hiding this comment.
Put these failures on test/dynamo_expected_failures
There was a problem hiding this comment.
Done. Note that two of the tests had to go in dynamo_skips though (one was passing despite being expected to fail and the other was passing on python 3.10 but not 3.13)
|
@williamwen42, can you review this one? Rob implemented the @rtimpe, we need to make sure the CPython tests are actually being traced by Dynamo and not skipped. |
williamwen42
approved these changes
Aug 29, 2025
|
@rtimpe can you rebase this PR? You can do this with |
rtimpe
added a commit
that referenced
this pull request
Sep 4, 2025
Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Fixes #161562 ghstack-source-id: f18a913 Pull-Request: #161670
rtimpe
added a commit
that referenced
this pull request
Sep 4, 2025
Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Fixes #161562 ghstack-source-id: f18a913 Pull-Request: #161670
rtimpe
added a commit
that referenced
this pull request
Sep 4, 2025
Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Fixes #161562 ghstack-source-id: 95ad2ab Pull-Request: #161670
rtimpe
added a commit
that referenced
this pull request
Sep 10, 2025
Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. ghstack-source-id: fa23eef Pull-Request: #161670
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Fixes pytorch#161562 Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ion (pytorch#161670)" This reverts commit 1463714. Reverted pytorch#161670 on behalf of https://github.com/jeanschmidt due to seems to have introduced https://github.com/pytorch/pytorch/actions/runs/17507127561/job/49733379267 and https://github.com/pytorch/pytorch/actions/runs/17507127561/job/49733379271 ([comment](pytorch#161670 (comment)))
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ion (pytorch#161670)" This reverts commit e254548. Reverted pytorch#161670 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it is failing a trunk test ([comment](pytorch#161670 (comment)))
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Fixes pytorch#161562 Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…ion (pytorch#161670)" This reverts commit 1463714. Reverted pytorch#161670 on behalf of https://github.com/jeanschmidt due to seems to have introduced https://github.com/pytorch/pytorch/actions/runs/17507127561/job/49733379267 and https://github.com/pytorch/pytorch/actions/runs/17507127561/job/49733379271 ([comment](pytorch#161670 (comment)))
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…ion (pytorch#161670)" This reverts commit e254548. Reverted pytorch#161670 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it is failing a trunk test ([comment](pytorch#161670 (comment)))
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Fixes pytorch#161562 Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…ion (pytorch#161670)" This reverts commit 1463714. Reverted pytorch#161670 on behalf of https://github.com/jeanschmidt due to seems to have introduced https://github.com/pytorch/pytorch/actions/runs/17507127561/job/49733379267 and https://github.com/pytorch/pytorch/actions/runs/17507127561/job/49733379271 ([comment](pytorch#161670 (comment)))
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…ion (pytorch#161670)" This reverts commit e254548. Reverted pytorch#161670 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it is failing a trunk test ([comment](pytorch#161670 (comment)))
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Fixes pytorch#161562 Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…ion (pytorch#161670)" This reverts commit 1463714. Reverted pytorch#161670 on behalf of https://github.com/jeanschmidt due to seems to have introduced https://github.com/pytorch/pytorch/actions/runs/17507127561/job/49733379267 and https://github.com/pytorch/pytorch/actions/runs/17507127561/job/49733379271 ([comment](pytorch#161670 (comment)))
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…ion (pytorch#161670)" This reverts commit e254548. Reverted pytorch#161670 on behalf of https://github.com/huydhn due to Sorry for reverting your change but it is failing a trunk test ([comment](pytorch#161670 (comment)))
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…orch#161670) Currently, user-defined classes inside of a compiled frame will cause the whole frame to be skipped by dynamo. This change defers the Unsupported exception until the __build_class__ builtin is actually called, which allows a graph break to be inserted. Pull Request resolved: pytorch#161670 Approved by: https://github.com/williamwen42, https://github.com/guilhermeleobas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Currently, user-defined classes inside of a compiled frame will cause the whole
frame to be skipped by dynamo. This change defers the Unsupported exception
until the build_class builtin is actually called, which allows a graph break
to be inserted.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela