-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Cleanup stale submodule directories after checkout #161748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/161748
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 23 PendingAs of commit fadd993 with merge base 9b67d8e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, would be nice to test on windows as well just to make sure we don't break
@pytorchbot merge -f "Hmm, this change absolutely can not be tested on pull request, can it?" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot revert -m "I put the check in the wrong place" -c weird |
@pytorchbot successfully started a revert job. Check the current status here. |
…)" This reverts commit f3c5a82. Reverted #161748 on behalf of https://github.com/malfet due to I put the check in the wrong place ([comment](#161748 (comment)))
@malfet your PR has been successfully reverted. |
Fixes #161510 Test plan: ``` % cd third_party/kineto % git checkout fe80f9319479265f7a208e615e16a363b993d50c; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was 5e75018 Fix Local Time on Windows Builds (#1104) HEAD is now at fe80f93 Fix MSVC Error (#1134) Submodule path 'libkineto/third_party/dynolog': checked out 'd2ffe0a4e3acace628db49974246b66fc3e85fb1' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp': checked out 'b1234816facfdda29845c46696a02998a4af115a' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/civetweb': checked out 'd7ba35bbb649209c66e582d5a0244ba988a15159' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/googletest': checked out 'e2239ee6043f73722e7aa812a459f54a28552929' Submodule path 'libkineto/third_party/fmt': checked out '40626af88bd7df9a5fb80be7b25ac85b122d6c21' Submodule path 'libkineto/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' % git checkout 5e75018; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was fe80f93 Fix MSVC Error (#1134) HEAD is now at 5e75018 Fix Local Time on Windows Builds (#1104) warning: unable to rmdir 'third_party/prometheus-cpp': Directory not empty Submodule path 'libkineto/third_party/dynolog': checked out '7d04a0053a845370ae06ce317a22a48e9edcc74e' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '58d77fa8070e8cec2dc1ed015d66b454c8d78850' Submodule path 'libkineto/third_party/fmt': checked out '0041a40c1350ba702d475b9c4ad62da77caea164' Submodule path 'libkineto/third_party/googletest': checked out '7aca84427f224eeed3144123d5230d5871e93347' % cd ../.. % git status HEAD detached from 649e397 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules) modified: third_party/kineto (untracked content) % time git submodule foreach --recursive git clean -ffdx ... git submodule foreach --recursive git clean -ffdx 0.47s user 0.96s system 88% cpu 1.625 total % git status HEAD detached from 649e397 ```
.github/workflows/_mac-build.yml
Outdated
# [see note: pytorch repo ref] | ||
- name: Checkout PyTorch | ||
uses: pytorch/pytorch/.github/actions/checkout-pytorch@main | ||
uses: pytorch/pytorch/.github/actions/checkout-pytorch@malfet-patch-1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is temporary for testing I guess?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, because otherwise it's a no-op that could not be tested...
This reverts commit d2482a3.
@pytorchbot merge -f "What can go wrong I wonder?" |
@pytorchbot revert -m "I still see the same failures, and could not understand, from the log whether those checks are running on not" |
❌ 🤖 pytorchbot command failed:
Try |
This reverts commit e13fe9a.
@pytorchbot revert -m "I still see the same failures, and could not understand, from the log whether those checks are running on not" -c weird |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 0e45023. Reverted #161748 on behalf of https://github.com/malfet due to I still see the same failures, and could not understand, from the log whether those checks are running on not ([comment](#161748 (comment)))
@malfet your PR has been successfully reverted. |
This reverts commit cabf23f.
@pytorchbot merge -f "Take four" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Fixes pytorch#161510 Test plan: ``` % cd third_party/kineto % git checkout fe80f9319479265f7a208e615e16a363b993d50c; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was 5e75018 Fix Local Time on Windows Builds (pytorch#1104) HEAD is now at fe80f93 Fix MSVC Error (pytorch#1134) Submodule path 'libkineto/third_party/dynolog': checked out 'd2ffe0a4e3acace628db49974246b66fc3e85fb1' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp': checked out 'b1234816facfdda29845c46696a02998a4af115a' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/civetweb': checked out 'd7ba35bbb649209c66e582d5a0244ba988a15159' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/googletest': checked out 'e2239ee6043f73722e7aa812a459f54a28552929' Submodule path 'libkineto/third_party/fmt': checked out '40626af88bd7df9a5fb80be7b25ac85b122d6c21' Submodule path 'libkineto/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' % git checkout 5e75018; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was fe80f93 Fix MSVC Error (pytorch#1134) HEAD is now at 5e75018 Fix Local Time on Windows Builds (pytorch#1104) warning: unable to rmdir 'third_party/prometheus-cpp': Directory not empty Submodule path 'libkineto/third_party/dynolog': checked out '7d04a0053a845370ae06ce317a22a48e9edcc74e' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '58d77fa8070e8cec2dc1ed015d66b454c8d78850' Submodule path 'libkineto/third_party/fmt': checked out '0041a40c1350ba702d475b9c4ad62da77caea164' Submodule path 'libkineto/third_party/googletest': checked out '7aca84427f224eeed3144123d5230d5871e93347' % cd ../.. % git status HEAD detached from 649e397 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules) modified: third_party/kineto (untracked content) % time git submodule foreach --recursive git clean -ffdx ... git submodule foreach --recursive git clean -ffdx 0.47s user 0.96s system 88% cpu 1.625 total % git status HEAD detached from 649e397 ``` Pull Request resolved: pytorch#161748 Approved by: https://github.com/atalman
…ch#161748)" This reverts commit f3c5a82. Reverted pytorch#161748 on behalf of https://github.com/malfet due to I put the check in the wrong place ([comment](pytorch#161748 (comment)))
Fixes pytorch#161510 Test plan: ``` % cd third_party/kineto % git checkout fe80f9319479265f7a208e615e16a363b993d50c; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was 5e75018 Fix Local Time on Windows Builds (pytorch#1104) HEAD is now at fe80f93 Fix MSVC Error (pytorch#1134) Submodule path 'libkineto/third_party/dynolog': checked out 'd2ffe0a4e3acace628db49974246b66fc3e85fb1' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp': checked out 'b1234816facfdda29845c46696a02998a4af115a' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/civetweb': checked out 'd7ba35bbb649209c66e582d5a0244ba988a15159' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/googletest': checked out 'e2239ee6043f73722e7aa812a459f54a28552929' Submodule path 'libkineto/third_party/fmt': checked out '40626af88bd7df9a5fb80be7b25ac85b122d6c21' Submodule path 'libkineto/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' % git checkout 5e75018; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was fe80f93 Fix MSVC Error (pytorch#1134) HEAD is now at 5e75018 Fix Local Time on Windows Builds (pytorch#1104) warning: unable to rmdir 'third_party/prometheus-cpp': Directory not empty Submodule path 'libkineto/third_party/dynolog': checked out '7d04a0053a845370ae06ce317a22a48e9edcc74e' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '58d77fa8070e8cec2dc1ed015d66b454c8d78850' Submodule path 'libkineto/third_party/fmt': checked out '0041a40c1350ba702d475b9c4ad62da77caea164' Submodule path 'libkineto/third_party/googletest': checked out '7aca84427f224eeed3144123d5230d5871e93347' % cd ../.. % git status HEAD detached from 649e397 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules) modified: third_party/kineto (untracked content) % time git submodule foreach --recursive git clean -ffdx ... git submodule foreach --recursive git clean -ffdx 0.47s user 0.96s system 88% cpu 1.625 total % git status HEAD detached from 649e397 ``` Pull Request resolved: pytorch#161748 Approved by: https://github.com/atalman
…61748)" This reverts commit 0e45023. Reverted pytorch#161748 on behalf of https://github.com/malfet due to I still see the same failures, and could not understand, from the log whether those checks are running on not ([comment](pytorch#161748 (comment)))
Fixes pytorch#161510 Test plan: ``` % cd third_party/kineto % git checkout fe80f9319479265f7a208e615e16a363b993d50c; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was 5e75018 Fix Local Time on Windows Builds (pytorch#1104) HEAD is now at fe80f93 Fix MSVC Error (pytorch#1134) Submodule path 'libkineto/third_party/dynolog': checked out 'd2ffe0a4e3acace628db49974246b66fc3e85fb1' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp': checked out 'b1234816facfdda29845c46696a02998a4af115a' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/civetweb': checked out 'd7ba35bbb649209c66e582d5a0244ba988a15159' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/googletest': checked out 'e2239ee6043f73722e7aa812a459f54a28552929' Submodule path 'libkineto/third_party/fmt': checked out '40626af88bd7df9a5fb80be7b25ac85b122d6c21' Submodule path 'libkineto/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' % git checkout 5e75018; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was fe80f93 Fix MSVC Error (pytorch#1134) HEAD is now at 5e75018 Fix Local Time on Windows Builds (pytorch#1104) warning: unable to rmdir 'third_party/prometheus-cpp': Directory not empty Submodule path 'libkineto/third_party/dynolog': checked out '7d04a0053a845370ae06ce317a22a48e9edcc74e' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '58d77fa8070e8cec2dc1ed015d66b454c8d78850' Submodule path 'libkineto/third_party/fmt': checked out '0041a40c1350ba702d475b9c4ad62da77caea164' Submodule path 'libkineto/third_party/googletest': checked out '7aca84427f224eeed3144123d5230d5871e93347' % cd ../.. % git status HEAD detached from 649e397 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules) modified: third_party/kineto (untracked content) % time git submodule foreach --recursive git clean -ffdx ... git submodule foreach --recursive git clean -ffdx 0.47s user 0.96s system 88% cpu 1.625 total % git status HEAD detached from 649e397 ``` Pull Request resolved: pytorch#161748 Approved by: https://github.com/atalman
…61748)" This reverts commit 0e45023. Reverted pytorch#161748 on behalf of https://github.com/malfet due to I still see the same failures, and could not understand, from the log whether those checks are running on not ([comment](pytorch#161748 (comment)))
Fixes pytorch#161510 Test plan: ``` % cd third_party/kineto % git checkout fe80f9319479265f7a208e615e16a363b993d50c; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was 5e75018 Fix Local Time on Windows Builds (pytorch#1104) HEAD is now at fe80f93 Fix MSVC Error (pytorch#1134) Submodule path 'libkineto/third_party/dynolog': checked out 'd2ffe0a4e3acace628db49974246b66fc3e85fb1' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp': checked out 'b1234816facfdda29845c46696a02998a4af115a' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/civetweb': checked out 'd7ba35bbb649209c66e582d5a0244ba988a15159' Submodule path 'libkineto/third_party/dynolog/third_party/prometheus-cpp/3rdparty/googletest': checked out 'e2239ee6043f73722e7aa812a459f54a28552929' Submodule path 'libkineto/third_party/fmt': checked out '40626af88bd7df9a5fb80be7b25ac85b122d6c21' Submodule path 'libkineto/third_party/googletest': checked out '52eb8108c5bdec04579160ae17225d66034bd723' % git checkout 5e75018; git submodule update --init --recursive M libkineto/third_party/dynolog M libkineto/third_party/fmt M libkineto/third_party/googletest Previous HEAD position was fe80f93 Fix MSVC Error (pytorch#1134) HEAD is now at 5e75018 Fix Local Time on Windows Builds (pytorch#1104) warning: unable to rmdir 'third_party/prometheus-cpp': Directory not empty Submodule path 'libkineto/third_party/dynolog': checked out '7d04a0053a845370ae06ce317a22a48e9edcc74e' Submodule path 'libkineto/third_party/dynolog/third_party/googletest': checked out '58d77fa8070e8cec2dc1ed015d66b454c8d78850' Submodule path 'libkineto/third_party/fmt': checked out '0041a40c1350ba702d475b9c4ad62da77caea164' Submodule path 'libkineto/third_party/googletest': checked out '7aca84427f224eeed3144123d5230d5871e93347' % cd ../.. % git status HEAD detached from 649e397 Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules) modified: third_party/kineto (untracked content) % time git submodule foreach --recursive git clean -ffdx ... git submodule foreach --recursive git clean -ffdx 0.47s user 0.96s system 88% cpu 1.625 total % git status HEAD detached from 649e397 ``` Pull Request resolved: pytorch#161748 Approved by: https://github.com/atalman
Fixes #161510
Test plan: