Skip to content

Conversation

dolpm
Copy link
Contributor

@dolpm dolpm commented Sep 3, 2025

if the user doesn't provide their own guard filter fn, we should by default filter global guards.

pytest test/dynamo/test_aot_compile.py

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela

@dolpm dolpm requested a review from zhxchen17 September 3, 2025 19:44
@dolpm dolpm added the topic: not user facing topic category label Sep 3, 2025
Copy link

pytorch-bot bot commented Sep 3, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162090

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 6eaec50 with merge base f3cebec (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@dolpm dolpm force-pushed the remote/aot-precompile-default-guard-filter branch from e261a83 to b23f2bb Compare September 3, 2025 21:25
@zhxchen17
Copy link
Contributor

@dolpm seems a rebase is needed

@dolpm dolpm force-pushed the remote/aot-precompile-default-guard-filter branch from b23f2bb to 6f85f59 Compare September 5, 2025 16:53
@dolpm dolpm force-pushed the remote/aot-precompile-default-guard-filter branch from 6f85f59 to 6eaec50 Compare September 5, 2025 17:09
@dolpm
Copy link
Contributor Author

dolpm commented Sep 5, 2025

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 5, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

daisyden pushed a commit to daisyden/pytorch that referenced this pull request Sep 8, 2025
if the user doesn't provide their own guard filter fn, we should by default filter global guards.

pytest test/dynamo/test_aot_compile.py

Pull Request resolved: pytorch#162090
Approved by: https://github.com/zhxchen17
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
if the user doesn't provide their own guard filter fn, we should by default filter global guards.

pytest test/dynamo/test_aot_compile.py

Pull Request resolved: pytorch#162090
Approved by: https://github.com/zhxchen17
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
if the user doesn't provide their own guard filter fn, we should by default filter global guards.

pytest test/dynamo/test_aot_compile.py

Pull Request resolved: pytorch#162090
Approved by: https://github.com/zhxchen17
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
if the user doesn't provide their own guard filter fn, we should by default filter global guards.

pytest test/dynamo/test_aot_compile.py

Pull Request resolved: pytorch#162090
Approved by: https://github.com/zhxchen17
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
if the user doesn't provide their own guard filter fn, we should by default filter global guards.

pytest test/dynamo/test_aot_compile.py

Pull Request resolved: pytorch#162090
Approved by: https://github.com/zhxchen17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants