[Dynamo] Don't guard data ptrs by default with mark_static_address #162208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162208
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d14380c with merge base 69a25f6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
mlazos
added
release notes: dynamo
ciflow/trunk
|
Test failing. Good to go from my side after the branch cut (which should be today). |
anijain2305
approved these changes
Sep 8, 2025
mlazos
force-pushed
the
mlazos/mark-static-update
branch
from
898acf4 to
d14380c
Compare
|
From Ed: Does this cause silent incorrectness if the user uses it with the old default arg: |
Merge failedReason: Comment with id 3282184494 not found Details for Dev Infra teamRaised by workflow job |
|
Reviewing the PR this looks relatively safe |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
markc-614
pushed a commit
to markc-614/pytorch
that referenced
this pull request
Sep 17, 2025
…ytorch#162208) Fixes pytorch#156377 Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile. Pull Request resolved: pytorch#162208 Approved by: https://github.com/anijain2305
mansiag05
pushed a commit
to mansiag05/pytorch
that referenced
this pull request
Sep 22, 2025
…ytorch#162208) Fixes pytorch#156377 Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile. Pull Request resolved: pytorch#162208 Approved by: https://github.com/anijain2305
cleonard530
pushed a commit
to cleonard530/pytorch
that referenced
this pull request
Sep 22, 2025
…ytorch#162208) Fixes pytorch#156377 Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile. Pull Request resolved: pytorch#162208 Approved by: https://github.com/anijain2305
dsashidh
pushed a commit
to dsashidh/pytorch
that referenced
this pull request
Sep 26, 2025
…ytorch#162208) Fixes pytorch#156377 Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile. Pull Request resolved: pytorch#162208 Approved by: https://github.com/anijain2305
hoshibara
pushed a commit
to hoshibara/pytorch
that referenced
this pull request
Oct 22, 2025
…ytorch#162208) Fixes pytorch#156377 Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile. Pull Request resolved: pytorch#162208 Approved by: https://github.com/anijain2305
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156377
Since we now re-record cudagraphs, it's not necessary to guard by default anymore and induce a full recompile.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela