Add -Wno-ctad-maybe-unsupported compiler flag #162223

0xjeffro · 2025-09-04T22:43:42Z

When running bazel build, we (Google) run into the following error.
The -Wctad-maybe-unsupported warning would be raised to an error and break the build in certain cases.
So, we propose to suppress the warning to make the build with bazel more smooth.

This is the error message we got:

c10/util/IntrusiveList.h:166:12: error: 'std::reverse_iterator' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported]
  166 |     return std::reverse_iterator{end()};
      |            ^
c10/test/util/IntrusiveList_test.cpp:24:18: note: in instantiation of member function 'c10::IntrusiveList<(anonymous namespace)::ListItem>::rbegin' requested here
   24 |     auto it = c1.rbegin();
      |                  ^
c10/test/util/IntrusiveList_test.cpp:43:5: note: in instantiation of function template specialization '(anonymous namespace)::check_containers_equal<(anonymous namespace)::ListItem>' requested here
   43 |     check_containers_equal(l, v);
      |     ^
libcxx/include/__iterator/reverse_iterator.h:51:7: note: add a deduction guide to suppress this warning
   51 | class reverse_iterator
      |       ^
1 error generated.

@haifeng-jin

pytorch-bot · 2025-09-04T22:45:00Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162223

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ab9902e with merge base 4d4abec ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

ezyang · 2025-09-06T02:35:28Z

@pytorchbot merge

pytorchmergebot · 2025-09-06T02:37:29Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-06T02:48:28Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team

Raised by workflow job

ezyang · 2025-09-06T03:03:27Z

@pytorchbot merge

pytorchmergebot · 2025-09-06T03:05:17Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot · 2025-09-06T03:05:35Z

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / macos-py3-arm64 / build

Details for Dev Infra team

Raised by workflow job

haifeng-jin · 2025-09-06T03:21:06Z

@pytorchbot rebase

pytorchmergebot · 2025-09-06T03:22:35Z

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

Error Message: ``` c10/util/IntrusiveList.h:166:12: error: 'std::reverse_iterator' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] 166 | return std::reverse_iterator{end()}; | ^ c10/test/util/IntrusiveList_test.cpp:24:18: note: in instantiation of member function 'c10::IntrusiveList<(anonymous namespace)::ListItem>::rbegin' requested here 24 | auto it = c1.rbegin(); | ^ c10/test/util/IntrusiveList_test.cpp:43:5: note: in instantiation of function template specialization '(anonymous namespace)::check_containers_equal<(anonymous namespace)::ListItem>' requested here 43 | check_containers_equal(l, v); | ^ libcxx/include/__iterator/reverse_iterator.h:51:7: note: add a deduction guide to suppress this warning 51 | class reverse_iterator | ^ 1 error generated. ```

pytorchmergebot · 2025-09-06T03:22:38Z

Successfully rebased pr-1 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout pr-1 && git pull --rebase)

haifeng-jin · 2025-09-06T03:25:29Z

@pytorchbot merge

pytorch-bot · 2025-09-06T03:25:33Z

Pull workflow has not been scheduled for the PR yet. It could be because author doesn't have permissions to run those or skip-checks keywords were added to PR/commits, aborting merge. Please get/give approval for the workflows and/or remove skip ci decorators before next merge attempt. If you think this is a mistake, please contact PyTorch Dev Infra.

haifeng-jin · 2025-09-06T03:31:02Z

@pytorchbot merge

pytorchmergebot · 2025-09-06T03:32:49Z

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

@haifeng-jin

When running bazel build, we (Google) run into the following error. The `-Wctad-maybe-unsupported` warning would be raised to an error and break the build in certain cases. So, we propose to suppress the warning to make the build with bazel more smooth. This is the error message we got: ``` c10/util/IntrusiveList.h:166:12: error: 'std::reverse_iterator' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] 166 | return std::reverse_iterator{end()}; | ^ c10/test/util/IntrusiveList_test.cpp:24:18: note: in instantiation of member function 'c10::IntrusiveList<(anonymous namespace)::ListItem>::rbegin' requested here 24 | auto it = c1.rbegin(); | ^ c10/test/util/IntrusiveList_test.cpp:43:5: note: in instantiation of function template specialization '(anonymous namespace)::check_containers_equal<(anonymous namespace)::ListItem>' requested here 43 | check_containers_equal(l, v); | ^ libcxx/include/__iterator/reverse_iterator.h:51:7: note: add a deduction guide to suppress this warning 51 | class reverse_iterator | ^ 1 error generated. ``` @haifeng-jin Pull Request resolved: pytorch#162223 Approved by: https://github.com/ezyang

@haifeng-jin

When running bazel build, we (Google) run into the following error. The `-Wctad-maybe-unsupported` warning would be raised to an error and break the build in certain cases. So, we propose to suppress the warning to make the build with bazel more smooth. This is the error message we got: ``` c10/util/IntrusiveList.h:166:12: error: 'std::reverse_iterator' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] 166 | return std::reverse_iterator{end()}; | ^ c10/test/util/IntrusiveList_test.cpp:24:18: note: in instantiation of member function 'c10::IntrusiveList<(anonymous namespace)::ListItem>::rbegin' requested here 24 | auto it = c1.rbegin(); | ^ c10/test/util/IntrusiveList_test.cpp:43:5: note: in instantiation of function template specialization '(anonymous namespace)::check_containers_equal<(anonymous namespace)::ListItem>' requested here 43 | check_containers_equal(l, v); | ^ libcxx/include/__iterator/reverse_iterator.h:51:7: note: add a deduction guide to suppress this warning 51 | class reverse_iterator | ^ 1 error generated. ``` @haifeng-jin Pull Request resolved: pytorch#162223 Approved by: https://github.com/ezyang

@haifeng-jin

When running bazel build, we (Google) run into the following error. The `-Wctad-maybe-unsupported` warning would be raised to an error and break the build in certain cases. So, we propose to suppress the warning to make the build with bazel more smooth. This is the error message we got: ``` c10/util/IntrusiveList.h:166:12: error: 'std::reverse_iterator' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] 166 | return std::reverse_iterator{end()}; | ^ c10/test/util/IntrusiveList_test.cpp:24:18: note: in instantiation of member function 'c10::IntrusiveList<(anonymous namespace)::ListItem>::rbegin' requested here 24 | auto it = c1.rbegin(); | ^ c10/test/util/IntrusiveList_test.cpp:43:5: note: in instantiation of function template specialization '(anonymous namespace)::check_containers_equal<(anonymous namespace)::ListItem>' requested here 43 | check_containers_equal(l, v); | ^ libcxx/include/__iterator/reverse_iterator.h:51:7: note: add a deduction guide to suppress this warning 51 | class reverse_iterator | ^ 1 error generated. ``` @haifeng-jin Pull Request resolved: pytorch#162223 Approved by: https://github.com/ezyang

@haifeng-jin

When running bazel build, we (Google) run into the following error. The `-Wctad-maybe-unsupported` warning would be raised to an error and break the build in certain cases. So, we propose to suppress the warning to make the build with bazel more smooth. This is the error message we got: ``` c10/util/IntrusiveList.h:166:12: error: 'std::reverse_iterator' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] 166 | return std::reverse_iterator{end()}; | ^ c10/test/util/IntrusiveList_test.cpp:24:18: note: in instantiation of member function 'c10::IntrusiveList<(anonymous namespace)::ListItem>::rbegin' requested here 24 | auto it = c1.rbegin(); | ^ c10/test/util/IntrusiveList_test.cpp:43:5: note: in instantiation of function template specialization '(anonymous namespace)::check_containers_equal<(anonymous namespace)::ListItem>' requested here 43 | check_containers_equal(l, v); | ^ libcxx/include/__iterator/reverse_iterator.h:51:7: note: add a deduction guide to suppress this warning 51 | class reverse_iterator | ^ 1 error generated. ``` @haifeng-jin Pull Request resolved: pytorch#162223 Approved by: https://github.com/ezyang

@haifeng-jin

When running bazel build, we (Google) run into the following error. The `-Wctad-maybe-unsupported` warning would be raised to an error and break the build in certain cases. So, we propose to suppress the warning to make the build with bazel more smooth. This is the error message we got: ``` c10/util/IntrusiveList.h:166:12: error: 'std::reverse_iterator' may not intend to support class template argument deduction [-Werror,-Wctad-maybe-unsupported] 166 | return std::reverse_iterator{end()}; | ^ c10/test/util/IntrusiveList_test.cpp:24:18: note: in instantiation of member function 'c10::IntrusiveList<(anonymous namespace)::ListItem>::rbegin' requested here 24 | auto it = c1.rbegin(); | ^ c10/test/util/IntrusiveList_test.cpp:43:5: note: in instantiation of function template specialization '(anonymous namespace)::check_containers_equal<(anonymous namespace)::ListItem>' requested here 43 | check_containers_equal(l, v); | ^ libcxx/include/__iterator/reverse_iterator.h:51:7: note: add a deduction guide to suppress this warning 51 | class reverse_iterator | ^ 1 error generated. ``` @haifeng-jin Pull Request resolved: pytorch#162223 Approved by: https://github.com/ezyang

pytorch-bot bot added the topic: not user facing topic category label Sep 4, 2025

pytorchbot added the open source label Sep 4, 2025

haifeng-jin marked this pull request as ready for review September 5, 2025 01:47

haifeng-jin requested review from ezyang and kurtamohler September 5, 2025 02:12

ezyang approved these changes Sep 6, 2025

View reviewed changes

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2025

pytorchmergebot added the merging label Sep 6, 2025

pytorchmergebot removed the merging label Sep 6, 2025

pytorchmergebot added the merging label Sep 6, 2025

pytorchmergebot removed the merging label Sep 6, 2025

pytorchmergebot force-pushed the pr-1 branch from 54b1d43 to ab9902e Compare September 6, 2025 03:22

pytorch-bot bot removed the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2025

pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 6, 2025

pytorchmergebot added the merging label Sep 6, 2025

pytorchmergebot added the Merged label Sep 6, 2025

pytorchmergebot closed this in 28f4ab0 Sep 6, 2025

pytorchmergebot removed the merging label Sep 6, 2025

Add -Wno-ctad-maybe-unsupported compiler flag #162223

Add -Wno-ctad-maybe-unsupported compiler flag #162223

Uh oh!

Conversation

0xjeffro commented Sep 4, 2025 • edited by haifeng-jin Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Sep 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162223

✅ No Failures

Uh oh!

ezyang commented Sep 6, 2025

Uh oh!

pytorchmergebot commented Sep 6, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 6, 2025

Merge failed

Uh oh!

ezyang commented Sep 6, 2025

Uh oh!

pytorchmergebot commented Sep 6, 2025

Merge started

Uh oh!

pytorchmergebot commented Sep 6, 2025

Merge failed

Uh oh!

haifeng-jin commented Sep 6, 2025

Uh oh!

pytorchmergebot commented Sep 6, 2025

Uh oh!

pytorchmergebot commented Sep 6, 2025

Uh oh!

haifeng-jin commented Sep 6, 2025

Uh oh!

pytorch-bot bot commented Sep 6, 2025

Uh oh!

haifeng-jin commented Sep 6, 2025

Uh oh!

pytorchmergebot commented Sep 6, 2025

Merge started

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

0xjeffro commented Sep 4, 2025 •

edited by haifeng-jin

Loading

pytorch-bot bot commented Sep 4, 2025 •

edited

Loading