Remove unneeded manual unwrap optionals #16245
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
oncall: jit
wanchaol
reviewed
Jan 23, 2019
| raise ValueError("fractional_max_pool2d requires specifying either " | ||
| "an output_size or an output_ratio") | ||
| if output_size is None: | ||
| _output_ratio = _pair(torch.jit._unwrap_optional(output_ratio)) |
There was a problem hiding this comment.
This function throws an error if both output_size is None and output_ratio is None.
Then it checks if output_size is None, which therefore means output_ratio is not none. Since the NoneType inference doesn't do any reasoning like "either output_ratio or output_none is None" I included the manual unwrap. I could remove it by instead writing:
if output_size is None and output_ratio is not None:
wanchaol
reviewed
Jan 23, 2019
| raise ValueError("fractional_max_pool3d requires specifying either " | ||
| "an output_size or an output_ratio") | ||
| if output_size is None: | ||
| _output_ratio = _triple(torch.jit._unwrap_optional(output_ratio)) |
wanchaol
approved these changes
Jan 23, 2019
There was a problem hiding this comment.
@eellison is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove calls to torch.jit._unwrap_optional that are no longer needed.
The remaining instances would require control flow logic for exceptions.