-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[ONNX] Update export docstring #162622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Update export docstring #162622
Conversation
Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162622
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 34 PendingAs of commit 3687eac with merge base 582d278 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the ONNX export function's docstring to reflect the latest configuration changes, particularly that dynamo export is now the recommended and default approach for ONNX export.
- Reorganized function parameters to group backward compatibility and deprecated options separately
- Updated documentation to clarify that dynamo=True is the recommended and default way to export
- Enhanced parameter descriptions with more detailed explanations and usage guidance
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot merge -f "docs change only. Docs build CI passed" |
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot cherry-pick --onto release/2.9 --fixes "Documentation updates for torch.onnx.export" -c docs |
Update export docstring to reflect the latest configuration. Pull Request resolved: #162622 Approved by: https://github.com/titaiwangms (cherry picked from commit 7e2e83c)
Cherry picking #162622The cherry pick PR is at #162637 and it is linked with issue Documentation updates for torch.onnx.export. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
* [ONNX] Update export docstring (#162622) Update export docstring to reflect the latest configuration. Pull Request resolved: #162622 Approved by: https://github.com/titaiwangms (cherry picked from commit 7e2e83c) * Change fallback option to False in ONNX export * Change fallback parameter default to False --------- Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
Update export docstring to reflect the latest configuration. Pull Request resolved: pytorch#162622 Approved by: https://github.com/titaiwangms
Update export docstring to reflect the latest configuration. Pull Request resolved: pytorch#162622 Approved by: https://github.com/titaiwangms
Update export docstring to reflect the latest configuration. Pull Request resolved: pytorch#162622 Approved by: https://github.com/titaiwangms
Update export docstring to reflect the latest configuration. Pull Request resolved: pytorch#162622 Approved by: https://github.com/titaiwangms
Update export docstring to reflect the latest configuration.
cc @titaiwangms