Skip to content

Conversation

justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Sep 10, 2025

Update export docstring to reflect the latest configuration.

cc @titaiwangms

Signed-off-by: Justin Chu <justinchuby@users.noreply.github.com>
@justinchuby justinchuby added the module: onnx Related to torch.onnx label Sep 10, 2025
Copy link

pytorch-bot bot commented Sep 10, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162622

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 34 Pending

As of commit 3687eac with merge base 582d278 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Sep 10, 2025
@justinchuby justinchuby added the topic: docs topic category label Sep 10, 2025
@justinchuby justinchuby added this to the 2.9.0 milestone Sep 10, 2025
@titaiwangms titaiwangms requested a review from Copilot September 10, 2025 18:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the ONNX export function's docstring to reflect the latest configuration changes, particularly that dynamo export is now the recommended and default approach for ONNX export.

  • Reorganized function parameters to group backward compatibility and deprecated options separately
  • Updated documentation to clarify that dynamo=True is the recommended and default way to export
  • Enhanced parameter descriptions with more detailed explanations and usage guidance

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 10, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

@pytorchbot merge -f "docs change only. Docs build CI passed"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@justinchuby
Copy link
Collaborator Author

@pytorchbot cherry-pick --onto release/2.9 --fixes "Documentation updates for torch.onnx.export" -c docs

pytorchbot pushed a commit that referenced this pull request Sep 10, 2025
Update export docstring to reflect the latest configuration.

Pull Request resolved: #162622
Approved by: https://github.com/titaiwangms

(cherry picked from commit 7e2e83c)
@pytorchbot
Copy link
Collaborator

Cherry picking #162622

The cherry pick PR is at #162637 and it is linked with issue Documentation updates for torch.onnx.export. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

Camyll pushed a commit that referenced this pull request Sep 17, 2025
* [ONNX] Update export docstring (#162622)

Update export docstring to reflect the latest configuration.

Pull Request resolved: #162622
Approved by: https://github.com/titaiwangms

(cherry picked from commit 7e2e83c)

* Change fallback option to False in ONNX export

* Change fallback parameter default to False

---------

Co-authored-by: Justin Chu <justinchuby@users.noreply.github.com>
markc-614 pushed a commit to markc-614/pytorch that referenced this pull request Sep 17, 2025
Update export docstring to reflect the latest configuration.

Pull Request resolved: pytorch#162622
Approved by: https://github.com/titaiwangms
mansiag05 pushed a commit to mansiag05/pytorch that referenced this pull request Sep 22, 2025
Update export docstring to reflect the latest configuration.

Pull Request resolved: pytorch#162622
Approved by: https://github.com/titaiwangms
cleonard530 pushed a commit to cleonard530/pytorch that referenced this pull request Sep 22, 2025
Update export docstring to reflect the latest configuration.

Pull Request resolved: pytorch#162622
Approved by: https://github.com/titaiwangms
dsashidh pushed a commit to dsashidh/pytorch that referenced this pull request Sep 26, 2025
Update export docstring to reflect the latest configuration.

Pull Request resolved: pytorch#162622
Approved by: https://github.com/titaiwangms
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: docs topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants