[ci] Refactor the docs build workflow #16265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zou3519
force-pushed
the
ci_refactor_doc_build
branch
9 times, most recently
from
98ecf73 to
a6bcd54
Compare
zou3519
changed the title
In preparation for setting up a doc build job for stable docs, I wanted to refactor the workflow so that future changes will be easier. This PR the following changes: - Refactor the doc push script into a reusable command - Add command line options for the doc push script. These don't matter too much for now but will be useful for setting up future jobs for building different versions of the docs. - Instead of checking out pytorch/pytorch:master, we re-use the pytorch installation inside the docker image. - Change the sed in the script to a perl command. sed is annoyingly different across platforms; the perl command is more stable - Run the script in dry run mode (without pushing the doc build) whenever a PR is opened. This lets us test changes to the doc build workflow. Test Plan - I tested the doc build script locally with my own credentials and it worked fine. - Wait for the pytorch_doc_push CI. - After merging this PR, keep an eye on the pytorch_doc_push CI status.
zou3519
force-pushed
the
ci_refactor_doc_build
branch
from
a6bcd54 to
f3c2d2b
Compare
There was a problem hiding this comment.
@zou3519 has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zou3519
added a commit
to zou3519/pytorch
that referenced
this pull request
Jan 25, 2019
Summary: In preparation for setting up a doc build job for stable docs, I wanted to refactor the workflow so that future changes will be easier. This PR the following changes: - Refactor the doc push script into a reusable command - Add command line options for the doc push script. These don't matter too much for now but will be useful for setting up future jobs for building different versions of the docs. - Instead of checking out pytorch/pytorch:master, we re-use the pytorch installation inside the docker image. - Change the sed in the script to a perl command. sed is annoyingly different across platforms; the perl command is more stable - Run the script in dry run mode (without pushing the doc build) whenever a PR is opened. This lets us test changes to the doc build workflow. Test Plan - I tested the doc build script locally with my own credentials and it worked fine. - Wait for the pytorch_doc_push CI. - After merging this PR, keep an eye on the pytorch_doc_push CI status. Pull Request resolved: pytorch#16265 Differential Revision: D13803511 Pulled By: zou3519 fbshipit-source-id: 4564bca3e74d490f89a1d1da9fb8b98eb44bdbb1
soumith
pushed a commit
that referenced
this pull request
Jan 29, 2019
Summary: In preparation for setting up a doc build job for stable docs, I wanted to refactor the workflow so that future changes will be easier. This PR the following changes: - Refactor the doc push script into a reusable command - Add command line options for the doc push script. These don't matter too much for now but will be useful for setting up future jobs for building different versions of the docs. - Instead of checking out pytorch/pytorch:master, we re-use the pytorch installation inside the docker image. - Change the sed in the script to a perl command. sed is annoyingly different across platforms; the perl command is more stable - Run the script in dry run mode (without pushing the doc build) whenever a PR is opened. This lets us test changes to the doc build workflow. Test Plan - I tested the doc build script locally with my own credentials and it worked fine. - Wait for the pytorch_doc_push CI. - After merging this PR, keep an eye on the pytorch_doc_push CI status. Pull Request resolved: #16265 Differential Revision: D13803511 Pulled By: zou3519 fbshipit-source-id: 4564bca3e74d490f89a1d1da9fb8b98eb44bdbb1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for setting up a doc build job for stable docs, I wanted
to refactor the workflow so that future changes will be easier.
This PR the following changes:
These don't matter too much for now but will be useful
for setting up future jobs for building different versions of the
docs.
installation inside the docker image.
different across platforms; the perl command is more stable
whenever a PR is opened. This lets us test changes to the doc build workflow.
Test Plan
worked fine.