[scan] create fw and bw graphs via partitioning #162754
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Sep 11, 2025
pytorch-bot
bot
added
ciflow/inductor
module: dynamo
release notes: fx
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/162754
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit ac1971a with merge base 1d138e6 ( FLAKY - The following job failed but was likely due to flakiness present on trunk:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
zou3519
reviewed
Sep 19, 2025
Comment on lines
+1554
to
+1555
| and "ac_graph_id" in user.meta | ||
| and "ac_graph_id" in node.meta |
There was a problem hiding this comment.
We didn't go through aot_autograd so these two metas are not set. The prior logic only works when this meta exists.
zou3519
reviewed
Sep 19, 2025
| @@ -0,0 +1,362 @@ | |||
| import logging | |||
| from typing import Any, Callable, Union | |||
|
|
|||
There was a problem hiding this comment.
Do you have any tests? Are there no expecttests for scan forward+backward that need to be updated as a result of this change? if not we should add a test that demonstrates the partitioning is actually happening
There was a problem hiding this comment.
yeah, I can add some tests guarding this.
zou3519
reviewed
Sep 19, 2025
Comment on lines
+770
to
+771
| # TODO: torch.flip copies the tensor, we should optimize it away | ||
| [torch.flip(x, (0,)) for x in pytree.tree_flatten(bw_xs)[0]], |
There was a problem hiding this comment.
how are you thinking of optimizing it away?
There was a problem hiding this comment.
We could pass the reverse keyword all the way to inductor and do a reversed traverse there.
zou3519
approved these changes
Sep 19, 2025
cc ezyang SherlockNoMad EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
cc ezyang EikanWang jgong5 wenzhe-nrv voznesenskym penguinwu Guobing-Chen XiaobingSuper zhuhaozhe blzheng jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela SherlockNoMad [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
jainapurva
pushed a commit
that referenced
this pull request
Sep 29, 2025
maggiemoss
pushed a commit
to maggiemoss/pytorch
that referenced
this pull request
Sep 29, 2025
Pull Request resolved: pytorch#162754 Approved by: https://github.com/zou3519 ghstack dependencies: pytorch#161557, pytorch#161664, pytorch#161808, pytorch#162025, pytorch#161732
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
cc @ezyang @EikanWang @jgong5 @wenzhe-nrv @voznesenskym @penguinwu @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela @SherlockNoMad