[opaque obj] Allow non-effectful scriptobjs #163714
Closed
+152
−67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
This was referenced Sep 24, 2025
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163714
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 385e88f with merge base f9b81e2 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Sep 24, 2025
[ghstack-poisoned]
ydwu4
reviewed
Sep 24, 2025
[ghstack-poisoned]
[ghstack-poisoned]
[ghstack-poisoned]
This was referenced Sep 26, 2025
[ghstack-poisoned]
[ghstack-poisoned]
angelayi
requested review from
avikchaudhuri,
bdhirsh,
tugsbayasgalan and
zhxchen17
as code owners
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
zou3519
reviewed
Nov 1, 2025
zou3519
reviewed
Nov 1, 2025
zou3519
reviewed
Nov 1, 2025
cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Fixes functionalization so that we can run ops using ScriptObjects w/o needing effects. Previously we would run into an error when running functionalization on the TorchBindOpOverloads. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Fixes functionalization so that we can run ops using ScriptObjects w/o needing effects. Previously we would run into an error when running functionalization on the TorchBindOpOverloads. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Fixes functionalization so that we can run ops using ScriptObjects w/o needing effects. Previously we would run into an error when running functionalization on the TorchBindOpOverloads. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
This was referenced Nov 6, 2025
zou3519
reviewed
Nov 8, 2025
test/test_opaque_obj_v2.py
Outdated
| return (getitem_2, add)""", # noqa: B950 | ||
| ) | ||
|
|
||
| _deregister_effectful_op("_TestOpaqueObject::noisy_inject") |
Contributor
There was a problem hiding this comment.
Why is the deregister here? if it's to reset the state, you want a try-finally and this in the finally block. otherwise if there's an early return due to exception you might see flaky tests
Contributor
There was a problem hiding this comment.
Also can I just torch.library._register_effectful_op(
"_TestOpaqueObject::noisy_inject", None
) to undo this?
zou3519
reviewed
Nov 8, 2025
Comment on lines
+508
to
+510
| # When the function is a TorchBindOpOverload, meaning some of the | ||
| # inputs are FakeScriptObjects, we need to skip c++ dispatcher and | ||
| # dispatch in python because C++ dispatcher will check the schema |
Contributor
There was a problem hiding this comment.
What happens if you have a torchbindopoverload that mutates an input tensor? Did this case work before? Does it work now?
Contributor
Author
There was a problem hiding this comment.
I tried with a torchbindopoverload that mutates an input tensor and it gets correctly wrapped with auto_functionalize. This works before though! I added an expecttest in the following PR
zou3519
reviewed
Nov 8, 2025
Contributor
zou3519
left a comment
zou3519
left a comment
There was a problem hiding this comment.
seems reasonable, i just want to understand what happens in the case where we're mutating a tensor
Fixes functionalization so that we can run ops using ScriptObjects w/o needing effects. Previously we would run into an error when running functionalization on the TorchBindOpOverloads. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Fixes functionalization so that we can run ops using ScriptObjects w/o needing effects. Previously we would run into an error when running functionalization on the TorchBindOpOverloads. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
Fixes functionalization so that we can run ops using ScriptObjects w/o needing effects. Previously we would run into an error when running functionalization on the TorchBindOpOverloads. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben [ghstack-poisoned]
zou3519
approved these changes
Nov 12, 2025
Collaborator
|
Starting merge as part of PR stack under #167230 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 13, 2025
Pull Request resolved: #163936 Approved by: https://github.com/zou3519 ghstack dependencies: #163284, #163714
pytorchmergebot
pushed a commit
that referenced
this pull request
Nov 13, 2025
Pull Request resolved: #167230 Approved by: https://github.com/zou3519 ghstack dependencies: #163284, #163714, #163936
This was referenced Nov 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes functionalization so that we can run ops using ScriptObjects w/o needing effects. Previously we would run into an error when running functionalization on the TorchBindOpOverloads.
Stack from ghstack (oldest at bottom):
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben