Skip to content

Fix tensor creation with empty names crash #163957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix tensor creation with empty names crash #163957

wants to merge 1 commit into from

Conversation

arkadip-maitra
Copy link
Contributor

@arkadip-maitra arkadip-maitra commented Sep 26, 2025 •
edited by malfet
Loading

Partially fixes #148324

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Sep 26, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/163957

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8744605 with merge base d4e4f70 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@arkadip-maitra
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 26, 2025
@arkadip-maitra arkadip-maitra mentioned this pull request Sep 26, 2025
Open
@arkadip-maitra
Copy link
Contributor Author

@janeyx99 please approve this pr. its just the named tensor fix from pr #163535

malfet
malfet approved these changes Sep 26, 2025
View reviewed changes
Copy link
Contributor

@malfet malfet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not sure why we still care about named tensors though... They probably should be removed from the codebase

@malfet malfet added release notes: python_frontend python frontend release notes category topic: bug fixes topic category and removed topic: not user facing topic category labels Sep 26, 2025
@malfet malfet changed the title moving the named tensor fix from pr 163535 to this Fix tensor creation with empty names crash Sep 26, 2025
@malfet
Copy link
Contributor

malfet commented Sep 26, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Sep 26, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

jainapurva pushed a commit that referenced this pull request Sep 29, 2025
@arkadip-maitra @jainapurva
Fix tensor creation with empty names crash (#163957)
95c3eb7 
Partially fixes #148324

Pull Request resolved: #163957
Approved by: https://github.com/malfet, https://github.com/janeyx99
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@janeyx99 janeyx99 janeyx99 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: python_frontend python frontend release notes category topic: bug fixes topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

torch.linalg routines break for inputs of more than 2**32 elements

5 participants

@arkadip-maitra @malfet @pytorchmergebot @janeyx99 @pytorchbot