Skip to content

Conversation

XuehaiPan
Copy link
Collaborator

@XuehaiPan XuehaiPan commented Sep 30, 2025

[ghstack-poisoned]
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Sep 30, 2025
Copy link

pytorch-bot bot commented Sep 30, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164214

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 8699fa3 with merge base 3b4ad4a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Sep 30, 2025
@XuehaiPan XuehaiPan requested review from ezyang and malfet September 30, 2025 06:21
@XuehaiPan XuehaiPan added the better-engineering Relatively self-contained tasks for better engineering contributors label Sep 30, 2025
@XuehaiPan XuehaiPan changed the title Add notes for setting up dev venv with specific Python version [Easy] Add notes for setting up dev venv with specific Python version Sep 30, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Sep 30, 2025
[ghstack-poisoned]
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Sep 30, 2025
XuehaiPan added a commit to XuehaiPan/pytorch that referenced this pull request Sep 30, 2025
@XuehaiPan
Copy link
Collaborator Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 1, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorchmergebot pushed a commit that referenced this pull request Oct 2, 2025
Resolves #164010 (comment), cc @filipviz

Previously, the `checkout` subcommand would reuse the `venv`, while the `pull` subcommand would remove and recreate a fresh new `venv` (without prompting before deleting).

This PR:

- Keep and reuse the existing `venv` by default (both `pull` and `checkout`).
- Add a new `--fresh` option to delete and recreate a fresh new `venv`.
- Prompt the user for confirmation (add a new `--yes` option) before deleting the existing prefix path.

Pull Request resolved: #164215
Approved by: https://github.com/ezyang, https://github.com/malfet
ghstack dependencies: #162324, #164214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

better-engineering Relatively self-contained tasks for better engineering contributors ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants