remove check_is_size from test_misc.py #164667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

laithsakka wants to merge 11 commits into gh/laithsakka/296/base from gh/laithsakka/296/head

Contributor

laithsakka commented Oct 4, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela


          remove check_is_size from test_misc.py

7fd688a

[ghstack-poisoned]

This was referenced Oct 4, 2025

remove no longer needed torch._check_is_size calls from test_dynamic_shapes #164627

Closed

remove more no longer needed torch._check_is_size calls 1 #164630

Closed

pytorch-bot bot commented Oct 4, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164667

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (4 Unrelated Failures)

As of commit f9a62ad with merge base 1fc71d1 ():

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
inductor / unit-test / inductor-test / test (inductor_cpp_wrapper, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)
inductor / unit-test / inductor-test / test (inductor, 1, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (detected as infra flaky with no log or failing log classifier)

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

inductor / inductor-test / test (inductor_torchbench, 2, 2, linux.g5.4xlarge.nvidia.gpu) (gh) (trunk failure)
vision_maskrcnn

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Oct 4, 2025

do not suggest torch._check_is_size() #164664

Closed

remove size-like based size-oblivious special max simplifications #164665

Closed

pytorch-bot bot added ciflow/inductor module: dynamo labels

laithsakka added a commit that referenced this pull request


          remove check_is_size from test_misc.py

587ee94

ghstack-source-id: d1b038a
Pull Request resolved: #164667

laithsakka mentioned this pull request

use check_size instead of check_is_size in ops.py #164668

Closed

laithsakka requested review from ColinPeppler, bobrenjc93 and pianpwk

October 4, 2025 22:09


          Update on "remove check_is_size from test_misc.py"

e17a3c8

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

laithsakka added a commit that referenced this pull request


          remove check_is_size from test_misc.py

ebadd4e

ghstack-source-id: 99672a1
Pull Request resolved: #164667


          Update on "remove check_is_size from test_misc.py"

b0e87d6

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

This was referenced Oct 5, 2025

Fix issues with generalized_scatter and setitem allocated unbacked symbols. #164341

Closed

remove more check_is_size #164706

Closed

angelayi approved these changes

View reviewed changes


          Update on "remove check_is_size from test_misc.py"

518abf0

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

laithsakka added a commit that referenced this pull request


          remove check_is_size from test_misc.py

19206c7

ghstack-source-id: f81cc7e
Pull Request resolved: #164667


          Update on "remove check_is_size from test_misc.py"

9a8a4c5

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

laithsakka added a commit that referenced this pull request


          remove check_is_size from test_misc.py

09a6cdb

ghstack-source-id: 1235030
Pull Request resolved: #164667


          Update on "remove check_is_size from test_misc.py"

91087ef

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

laithsakka added a commit that referenced this pull request


          remove check_is_size from test_misc.py

aea1b3c

ghstack-source-id: f54f8b9
Pull Request resolved: #164667

laithsakka mentioned this pull request

remove more #164753

Closed


          Update on "remove check_is_size from test_misc.py"

c74ab29

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

laithsakka added a commit that referenced this pull request


          remove check_is_size from test_misc.py

7dbf97c

ghstack-source-id: 468b313
Pull Request resolved: #164667

laithsakka added the topic: not user facing label


          Update on "remove check_is_size from test_misc.py"

7c3d060

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

laithsakka added a commit that referenced this pull request


          remove check_is_size from test_misc.py

ffb21fc

ghstack-source-id: 2763da3
Pull Request resolved: #164667

laithsakka added 2 commits

October 6, 2025 13:37


          Update on "remove check_is_size from test_misc.py"

bfd8d75

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]


          Update on "remove check_is_size from test_misc.py"

3257a39

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

laithsakka added a commit that referenced this pull request


          remove check_is_size from test_misc.py

7a81fd0

ghstack-source-id: 2763da3
Pull Request resolved: #164667


          Update on "remove check_is_size from test_misc.py"

f9a62ad

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]

This was referenced Oct 7, 2025

more sizelike deprecation + remove expect_size #164803

Closed

remove expect_size c++ bindings and usages #164804

Closed

Contributor Author

laithsakka commented Oct 7, 2025

@pytorchbot merge

pytorch-bot bot added the ciflow/trunk label

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Oct 7, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

ef7e2ca

pytorchmergebot removed the merging label

laithsakka mentioned this pull request

more sizelike deprecation #164889

Closed

pytorchmergebot pushed a commit that referenced this pull request


          use check_size instead of check_is_size in ops.py (#164668)

2035f6b

Pull Request resolved: #164668
Approved by: https://github.com/angelayi
ghstack dependencies: #164664, #164665, #164667

pytorchmergebot pushed a commit that referenced this pull request


          remove more (#164753)

7158aa2

Pull Request resolved: #164753
Approved by: https://github.com/aorenste, https://github.com/mlazos
ghstack dependencies: #164664, #164665, #164667, #164668

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Merged module: dynamo topic: not user facing