Skip to content

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Oct 5, 2025

Stack from ghstack (oldest at bottom):

The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela

The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Oct 5, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164691

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit ec0dd48 with merge base d734166 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

anijain2305 added a commit that referenced this pull request Oct 5, 2025
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

ghstack-source-id: c9d6875
Pull Request resolved: #164691
@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request keep-going Don't stop on first failure, keep running tests until the end labels Oct 5, 2025
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Oct 6, 2025
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

ghstack-source-id: 8aa2961
Pull Request resolved: #164691
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Oct 6, 2025
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

ghstack-source-id: 71dbde5
Pull Request resolved: #164691
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Oct 6, 2025
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

ghstack-source-id: 5900ba5
Pull Request resolved: #164691
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela

[ghstack-poisoned]
anijain2305 added a commit that referenced this pull request Oct 6, 2025
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

ghstack-source-id: 79d84fc
Pull Request resolved: #164691
@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

Reverting PR 164691 failed

Reason: Command git -C /home/runner/work/pytorch/pytorch revert --no-edit 220a34118f40fab4f3f517556d6e1434139a1590 returned non-zero exit code 1

Auto-merging test/dynamo/test_aot_autograd.py
CONFLICT (content): Merge conflict in test/dynamo/test_aot_autograd.py
Auto-merging test/export/test_export.py
error: could not revert 220a34118f4... [export] Turn on install_free_tensors flag (#164691)
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git revert --continue".
hint: You can instead skip this commit with "git revert --skip".
hint: To abort and get back to the state before "git revert",
hint: run "git revert --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Details for Dev Infra team Raised by workflow job

anijain2305 added a commit that referenced this pull request Oct 13, 2025
anijain2305 added a commit that referenced this pull request Oct 13, 2025
pytorchmergebot pushed a commit that referenced this pull request Oct 13, 2025
This reverts commit 220a341.

Fixes #ISSUE_NUMBER

Pull Request resolved: #165353
Approved by: https://github.com/seemethere
pytorchmergebot added a commit that referenced this pull request Oct 14, 2025
This reverts commit 9166f61.

Reverted #165353 on behalf of https://github.com/seemethere due to This is causing merge conflicts since a dependent PR wasn't reverted ([comment](#165353 (comment)))
pytorchmergebot added a commit that referenced this pull request Oct 14, 2025
This reverts commit a3e3efe.

Reverted #163671 on behalf of https://github.com/seemethere due to We should've reverted this when we decided to revert #164691 since they were actually stacked ([comment](#163671 (comment)))
@seemethere
Copy link
Member

@pytorchbot revert -c ghfirst -m "Breaks some internal things, both me and author agreed that revert was the best course of action"

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Oct 14, 2025
This reverts commit 220a341.

Reverted #164691 on behalf of https://github.com/seemethere due to Breaks some internal things, both me and author agreed that revert was the best course of action ([comment](#164691 (comment)))
@pytorchmergebot
Copy link
Collaborator

@anijain2305 your PR has been successfully reverted.

anijain2305 added a commit that referenced this pull request Oct 14, 2025
@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Oct 15, 2025
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).

Pull Request resolved: pytorch#164691
Approved by: https://github.com/avikchaudhuri
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorevert: disable Disable autorevert for a specific PR ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fb-exported keep-going Don't stop on first failure, keep running tests until the end Merged meta-exported module: dynamo module: inductor release notes: export Reverted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants