-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[export] Turn on install_free_tensors flag #164691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The final step in removing the discrepancy between torch.compile(fullgraph=True) and torch.export(strict=True). [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164691
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit ec0dd48 with merge base d734166 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
The final step in removing the discrepancy between torch.compile(fullgraph=True) and torch.export(strict=True). cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]
The final step in removing the discrepancy between torch.compile(fullgraph=True) and torch.export(strict=True). cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]
The final step in removing the discrepancy between torch.compile(fullgraph=True) and torch.export(strict=True). cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]
The final step in removing the discrepancy between torch.compile(fullgraph=True) and torch.export(strict=True). cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx ipiszy chenyang78 kadeng muchulee8 amjames chauhang aakhundov coconutruben Lucaskabela [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@pytorchbot successfully started a revert job. Check the current status here. |
Reverting PR 164691 failedReason: Command
Details for Dev Infra teamRaised by workflow job |
This reverts commit 220a341.
This reverts commit 220a341.
This reverts commit 220a341. Fixes #ISSUE_NUMBER Pull Request resolved: #165353 Approved by: https://github.com/seemethere
This reverts commit 9166f61. Reverted #165353 on behalf of https://github.com/seemethere due to This is causing merge conflicts since a dependent PR wasn't reverted ([comment](#165353 (comment)))
This reverts commit a3e3efe. Reverted #163671 on behalf of https://github.com/seemethere due to We should've reverted this when we decided to revert #164691 since they were actually stacked ([comment](#163671 (comment)))
This fixes #71725. Differential Revision: [D83857880](https://our.internmc.facebook.com/intern/diff/D83857880) Pull Request resolved: #163671 Approved by: https://github.com/ezyang, https://github.com/albanD
@pytorchbot revert -c ghfirst -m "Breaks some internal things, both me and author agreed that revert was the best course of action" |
@pytorchbot successfully started a revert job. Check the current status here. |
This reverts commit 220a341. Reverted #164691 on behalf of https://github.com/seemethere due to Breaks some internal things, both me and author agreed that revert was the best course of action ([comment](#164691 (comment)))
@anijain2305 your PR has been successfully reverted. |
This reverts commit 220a341.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
The final step in removing the discrepancy between torch.compile(fullgraph=True) and torch.export(strict=True). Pull Request resolved: pytorch#164691 Approved by: https://github.com/avikchaudhuri
Stack from ghstack (oldest at bottom):
The final step in removing the discrepancy between
torch.compile(fullgraph=True) and torch.export(strict=True).
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben @Lucaskabela