-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[annotate] Copy fwd to bwd metadata for subgraphs as well #164795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/164795
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 92a2433 with merge base 4a6abba ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a comment for potential future issue if bw ndoes are not in the same subgraph as fw nodes.
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
…4795) The test is in the next PR. My older PR on dynamo annotate - pytorch#164678 is getting reverted due to unknown reasons, so difficult to add a test right now in this PR. When I reland, I can add a test for this as well. Pull Request resolved: pytorch#164795 Approved by: https://github.com/yushangdi ghstack dependencies: pytorch#164772
Stack from ghstack (oldest at bottom):
The test is in the next PR. My older PR on dynamo annotate - #164678 is getting reverted due to unknown reasons, so difficult to add a test right now in this PR. When I reland, I can add a test for this as well.