Skip to content

[CD] Do not propagate download.pytorch.org IP into container #165075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[CD] Do not propagate download.pytorch.org IP into container #165075

wants to merge 2 commits into from

Conversation

malfet
Copy link
Contributor

@malfet malfet commented Oct 9, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

Followup after #164969

Should fix binary build test failures

@malfet
Update
12906ef 
[ghstack-poisoned]
@malfet malfet requested a review from a team as a code owner October 9, 2025 17:32
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 9, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Oct 9, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165075

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 163 Pending

As of commit 9cd585c with merge base 322091d (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

malfet added a commit that referenced this pull request Oct 9, 2025
@malfet
[CD] Do not propagate download.pytorch.org IP into container
c19b95f 
Followup after #164969

Should fix binary build test failures

ghstack-source-id: c93c40f
Pull Request resolved: #165075
@malfet malfet added the ciflow/binaries Trigger all binary build and upload jobs on the PR label Oct 9, 2025
@malfet
Copy link
Contributor Author

malfet commented Oct 9, 2025

@pytorchbot merge -f "test jobs are green"

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@malfet
Update
9cd585c 
[ghstack-poisoned]
malfet added a commit that referenced this pull request Oct 9, 2025
@malfet
[CD] Do not propagate download.pytorch.org IP into container
c3de016 
Followup after #164969

Should fix binary build test failures

ghstack-source-id: f7e6dcc
Pull Request resolved: #165075
@malfet
Copy link
Contributor Author

malfet commented Oct 9, 2025

@pytorchbot merge -f "Linux binary builds are green"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pull bot pushed a commit to AmirulAndalib/pytorch that referenced this pull request Oct 9, 2025
@malfet @pytorchmergebot
[CD] Do not propagate download.pytorch.org IP into container (pytorch…
6d27a8e 
…#165075)

Followup after pytorch#164969

Should fix binary build test failures
Pull Request resolved: pytorch#165075
Approved by: https://github.com/seemethere, https://github.com/huydhn
ghstack dependencies: pytorch#164968, pytorch#164969
@pytorchmergebot
Copy link
Collaborator

This PR (#165075) was merged in 6d27a8e but it is still open, likely due to a Github bug, so mergebot is closing it manually. If you think this is a mistake, please feel free to reopen and contact Dev Infra.

@pytorch-auto-revert
Copy link

@pytorchbot revert -m "Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable" -c autorevert

This PR is attributed to have caused regression in:

Please investigate and fix the issues.

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

pytorchmergebot added a commit that referenced this pull request Oct 10, 2025
@pytorchmergebot
Revert "[CD] Do not propagate download.pytorch.org IP into container (#…
daea35d 
…165075)"

This reverts commit 6d27a8e.

Reverted #165075 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](#165075 (comment)))
@pytorchmergebot
Copy link
Collaborator

@malfet your PR has been successfully reverted.

@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Oct 10, 2025
@malfet
Copy link
Contributor Author

malfet commented Oct 10, 2025

@pytorchbot merge -f "Let's fight bots with bots, I'm not seeing the regression"

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@malfet @Chao1Han
[CD] Do not propagate download.pytorch.org IP into container (pytorch…
f491d39 
…#165075)

Followup after pytorch#164969

Should fix binary build test failures
Pull Request resolved: pytorch#165075
Approved by: https://github.com/seemethere, https://github.com/huydhn
ghstack dependencies: pytorch#164968, pytorch#164969
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@pytorchmergebot @Chao1Han
Revert "[CD] Do not propagate download.pytorch.org IP into container (p…
64b9671 
…ytorch#165075)"

This reverts commit 6d27a8e.

Reverted pytorch#165075 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](pytorch#165075 (comment)))
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@malfet @Chao1Han
[CD] Do not propagate download.pytorch.org IP into container (pytorch…
a64f8ef 
…#165075)

Followup after pytorch#164969

Should fix binary build test failures
Pull Request resolved: pytorch#165075
Approved by: https://github.com/seemethere, https://github.com/huydhn
ghstack dependencies: pytorch#164968, pytorch#164969
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@seemethere seemethere seemethere approved these changes

Assignees

No one assigned

Labels

ci-no-td Do not run TD on this PR ciflow/binaries Trigger all binary build and upload jobs on the PR Merged Reverted topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@malfet @pytorchmergebot @huydhn @seemethere