Skip to content

[torch/utils][Code Clean] Clean asserts in torch/utils/_sympy #165279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[torch/utils][Code Clean] Clean asserts in torch/utils/_sympy #165279

wants to merge 1 commit into from

Conversation

KarhouTam
Copy link
Contributor

@KarhouTam KarhouTam commented Oct 13, 2025 •
edited by pytorch-bot bot
Loading

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165279

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ You can merge normally! (3 Unrelated Failures)

As of commit e9bf69c with merge base 992857e (image):

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Oct 13, 2025
@KarhouTam KarhouTam mentioned this pull request Oct 13, 2025
Open
2 tasks
@KarhouTam
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Oct 13, 2025
@KarhouTam
Copy link
Contributor Author

@pytorchbot label "module: python frontend" "module: error checking"

@pytorch-bot pytorch-bot bot added module: error checking Bugs related to incorrect/lacking error checking module: python frontend For issues relating to PyTorch's Python frontend labels Oct 13, 2025
@KarhouTam
Copy link
Contributor Author

KarhouTam commented Oct 13, 2025 •
edited
Loading

cc @FFFrog @albanD PTAL

@soulitzer soulitzer requested a review from albanD October 13, 2025 15:34
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Oct 13, 2025
albanD
albanD approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit on one of the condition flip. But SGTM !

@albanD
Copy link
Collaborator

albanD commented Oct 13, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 13, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

The merge job was canceled or timed out. This most often happen if two merge requests were issued for the same PR, or if merge job was waiting for more than 6 hours for tests to finish. In later case, please do not hesitate to reissue the merge command
For more information see pytorch-bot wiki.

@KarhouTam
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

KarhouTam added a commit to KarhouTam/pytorch that referenced this pull request Oct 14, 2025
@KarhouTam
Fixing small nit in torch/utils/_sympy/functions.py
0edaf00 
An additional patch, suggested by @albanD in pytorch#165279 (review)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: error checking Bugs related to incorrect/lacking error checking module: python frontend For issues relating to PyTorch's Python frontend open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@KarhouTam @albanD @pytorchmergebot @soulitzer @pytorchbot