Skip to content

[Code Clean] Replace std::runtime_error with TORCH_CHECK #165305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Code Clean] Replace std::runtime_error with TORCH_CHECK #165305

wants to merge 1 commit into from

Conversation

orangeH25
Copy link
Contributor

@orangeH25 orangeH25 commented Oct 13, 2025 •
edited by pytorch-bot bot
Loading

Fixes part of #148114

Including:

  • torch/csrc/distributed

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @pragupta @msaroufim @dcci

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Oct 13, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165305

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit 3e8947d with merge base 59ad8f1 (image):

FLAKY - The following job failed but was likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added oncall: distributed Add this issue/PR to distributed oncall triage queue release notes: distributed (c10d) release notes category labels Oct 13, 2025
@orangeH25
Copy link
Contributor Author

PTAL @FFFrog @albanD , thanks!

FFFrog
FFFrog approved these changes Oct 13, 2025
View reviewed changes
Copy link
Collaborator

@FFFrog FFFrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM, thank you.

@FFFrog FFFrog requested a review from albanD October 14, 2025 03:30
albanD
albanD approved these changes Oct 17, 2025
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@albanD
Copy link
Collaborator

albanD commented Oct 17, 2025

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Oct 17, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
@orangeH25 @Chao1Han
[Code Clean] Replace std::runtime_error with TORCH_CHECK (pytorch#165305
3a89735 
)

Fixes part of pytorch#148114

Including:

- torch/csrc/distributed

Pull Request resolved: pytorch#165305
Approved by: https://github.com/FFFrog, https://github.com/albanD
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@FFFrog FFFrog FFFrog approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged oncall: distributed Add this issue/PR to distributed oncall triage queue open source release notes: distributed (c10d) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@orangeH25 @albanD @pytorchmergebot @FFFrog @pytorchbot