use statically_known_leq & *=2 instead of bound_sympy in persistent rblock #165657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

eellison wants to merge 2 commits into gh/eellison/850/base from gh/eellison/850/head

+6 −10

Contributor

eellison commented Oct 16, 2025 •

edited

Loading

Stack from ghstack (oldest at bottom):

-> use statically_known_leq & *=2 instead of bound_sympy in persistent rblock #165657

While these should be equivalent, we've found instances where they are not, and an error was caused. update until we figure out underlying issue.

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

Differential Revision: D84835898


          Update

8b68e06

[ghstack-poisoned]

pytorch-bot bot commented Oct 16, 2025 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165657

📄 Preview Python docs built from this PR
📄 Preview C++ docs built from this PR
❓ Need help or want to give feedback on the CI? Visit the bot commands wiki

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit a883af7 with merge base 69b0591 ():

NEW FAILURE - The following job has failed:

trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge) (gh)
examples/models/test/test_export.py::ExportTest::test_ic3_export_to_executorch

This comment was automatically generated by Dr. CI and updates every 15 minutes.

pytorch-bot bot added ciflow/inductor module: inductor labels

eellison added a commit that referenced this pull request


          use statically_known_leq & *=2 instead of bound_sympy in persistent r…

88c83a8

…block

ghstack-source-id: 8fff632
Pull Request resolved: #165657

Contributor Author

eellison commented Oct 16, 2025

@eellison has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

pytorch-bot bot added the ciflow/trunk label

bobrenjc93 approved these changes

View reviewed changes

eellison added the topic: not user facing label


          Update

a883af7

[ghstack-poisoned]

eellison added a commit that referenced this pull request


          use statically_known_leq & *=2 instead of bound_sympy in persistent r…

2231d04

…block

ghstack-source-id: b9ebbb5
Pull Request resolved: #165657

Contributor Author

eellison commented Oct 16, 2025

@eellison has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

3 similar comments

Contributor Author

eellison commented Oct 16, 2025

@eellison has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

eellison commented Oct 16, 2025

@eellison has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor Author

eellison commented Oct 16, 2025

@eellison has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Contributor

facebook-github-bot commented Oct 17, 2025

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Oct 17, 2025

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

Collaborator

pytorchmergebot commented Oct 17, 2025

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge)

Details for Dev Infra team

Raised by workflow job

pytorchmergebot removed the merging label

Contributor Author

eellison commented Oct 17, 2025

@pytorchbot merge -i

pytorchmergebot added the merging label

Collaborator

pytorchmergebot commented Oct 17, 2025

Merge started

Your change will be merged while ignoring the following 1 checks: trunk / linux-jammy-py3-clang12-executorch / test (executorch, 1, 1, lf.linux.2xlarge)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging

Check the merge workflow status
here

pytorchmergebot added the Merged label

pytorchmergebot closed this in

861cdb8

pytorchmergebot removed the merging label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Merged module: inductor topic: not user facing