-
Notifications
You must be signed in to change notification settings - Fork 25.6k
[dynamo][misc] Replace UserFunctionVariable with VariableTracker build #165707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Audit: To prevent future issues with functools.partial or callable objects. [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165707
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 89bdd6d with merge base 03f3f78 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for propagating this through the codebase!
Probably don't need comments here since it is |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
@anijain2305 your PR has been reverted as part of the stack under #165706. |
…ker build (#165707)" This reverts commit 630520b. Reverted #165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](#165706 (comment)))
…racker build" Audit: To prevent future issues with functools.partial or callable objects. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
…racker build" Audit: To prevent future issues with functools.partial or callable objects. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
pytorch#165707) Audit: To prevent future issues with functools.partial or callable objects. Pull Request resolved: pytorch#165707 Approved by: https://github.com/Lucaskabela ghstack dependencies: pytorch#165683, pytorch#165706
…ker build (pytorch#165707)" This reverts commit 630520b. Reverted pytorch#165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](pytorch#165706 (comment)))
Stack from ghstack (oldest at bottom):
Audit: To prevent future issues with functools.partial or callable
objects.
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela