Skip to content

Conversation

anijain2305
Copy link
Contributor

@anijain2305 anijain2305 commented Oct 17, 2025

Audit: To prevent future issues with functools.partial or callable
objects.

[ghstack-poisoned]
Copy link

pytorch-bot bot commented Oct 17, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/165707

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 89bdd6d with merge base 03f3f78 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

anijain2305 added a commit that referenced this pull request Oct 17, 2025
Audit: To prevent future issues with functools.partial or callable
objects.

ghstack-source-id: aa3e1d7
Pull Request resolved: #165707
@anijain2305 anijain2305 added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category labels Oct 17, 2025
Copy link
Contributor

@Lucaskabela Lucaskabela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for propagating this through the codebase!

@Lucaskabela
Copy link
Contributor

Probably don't need comments here since it is misc.py - I am more concerned with documenting the reaasoning inside the user_defined variable class itself

@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

@anijain2305 your PR has been reverted as part of the stack under #165706.

pytorchmergebot added a commit that referenced this pull request Oct 20, 2025
…ker build (#165707)"

This reverts commit 630520b.

Reverted #165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](#165706 (comment)))
@pytorchmergebot pytorchmergebot added Reverted ci-no-td Do not run TD on this PR labels Oct 20, 2025
…racker build"

Audit: To prevent future issues with functools.partial or callable
objects.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
…racker build"

Audit: To prevent future issues with functools.partial or callable
objects.

cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela

[ghstack-poisoned]
@anijain2305
Copy link
Contributor Author

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
pytorch#165707)

Audit: To prevent future issues with functools.partial or callable
objects.

Pull Request resolved: pytorch#165707
Approved by: https://github.com/Lucaskabela
ghstack dependencies: pytorch#165683, pytorch#165706
Chao1Han pushed a commit to Chao1Han/pytorch that referenced this pull request Oct 21, 2025
…ker build (pytorch#165707)"

This reverts commit 630520b.

Reverted pytorch#165707 on behalf of https://github.com/clee2000 due to breaking internal tests D84961097 ([comment](pytorch#165706 (comment)))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-no-td Do not run TD on this PR ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo Reverted topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants