[dynamo, nested graph breaks] remove _dynamo.utils.counter patch on inlined tx'es #166015
+27
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nlined tx'es [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166015
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit 511468b with merge base a988510 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Oct 21, 2025
… patch on inlined tx'es" cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Lucaskabela
reviewed
Oct 21, 2025
| # Hierarchically, tx can be seen as the parent of the inline tracer | ||
| # created on call_function. Any exception needs to be propagated to tx | ||
| # for Dynamo to behave correctly | ||
| with patch.dict(counters, {"unimplemented": counters["inline_call"]}): |
There was a problem hiding this comment.
Can we run this with context manager tests? Seems that was the last time this patch was moved so may be worth double checking those tests.
Presuming those are green (and since nothing showing in CI), we can approve
… patch on inlined tx'es" This `patch.dict(counters, ...` appears to be ancient code that doesn't really seem to be doing anything? It causes issues in nested graph breaks because the patch cleanup clears out the record of the nested graph break. Removing the patch to see if it's even needed in the first place. cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang amjames Lucaskabela [ghstack-poisoned]
Lucaskabela
approved these changes
Oct 27, 2025
|
Starting merge as part of PR stack under #166016 |
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 28, 2025
…graph breaks (#165808) Previously, we would completely skip building and calling any resume function if the leaf frame's resume instruction was RETURN_VALUE/RETURN_CONST. Now, we only skip building/calling resume functions for frames that are resuming on RETURN_VALUE. Pull Request resolved: #165808 Approved by: https://github.com/Lucaskabela ghstack dependencies: #166013, #166015
pytorchmergebot
pushed a commit
that referenced
this pull request
Oct 28, 2025
…rs; enable nested_graph_breaks in test_ctx_manager.py and test_generator.py (#165809) Generators should not support nested graph breaks. Pull Request resolved: #165809 Approved by: https://github.com/Lucaskabela, https://github.com/guilhermeleobas ghstack dependencies: #166013, #166015, #165808
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This
patch.dict(counters, ...appears to be ancient code that doesn't really seem to be doing anything? It causes issues in nested graph breaks because the patch cleanup clears out the record of the nested graph break. Removing the patch to see if it's even needed in the first place.cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames @Lucaskabela