-
Notifications
You must be signed in to change notification settings - Fork 25.7k
[ONNX] Cover all FX passes into backed size oblivious #166151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ONNX] Cover all FX passes into backed size oblivious #166151
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/166151
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 542035e with merge base 5a4997d ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Could you add a reference in the PR description?
Updated a repro |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
| # Reassign the graph module to save some runtime. | ||
| exported_program._graph_module = graph_module | ||
| return exported_program | ||
| with ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add the example you found as a unit test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will submit a follow-up
Follow-up #166151 Pull Request resolved: #166196 Approved by: https://github.com/justinchuby
Found a bug that after
run_decomposition(), the shape could be fixed to 1. It's caused by the fact that all FX graph (related to shape inference) surgery should happen inside backed size oblivious patch.