-
Notifications
You must be signed in to change notification settings - Fork 25.9k
distributed/debug: add an HTTP server for debugging running jobs #167395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167395
Note: Links to docs will display an error until the docs builds have been completed. ❌ 7 New FailuresAs of commit d9bd0f2 with merge base bfddfde ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
67f237a to
04c8da3
Compare
9e781cb to
38bb262
Compare
d8dc8f4 to
0eb983b
Compare
34c05d7 to
5bf46e3
Compare
fduwjj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm.
|
@atalman these seem like broken infr and unrelated to this PR, good to land? |
5bf46e3 to
d9bd0f2
Compare
|
From HUD those issues are broken on trunk |
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 mandatory check(s) failed. The first few are:
Dig deeper by viewing the failures on hud |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 7 checks: Build manywheel docker images / manylinuxaarch64-builder:cuda13.0, docker-builds / docker-build (pytorch-linux-jammy-aarch64-py3.10-gcc13, linux.arm64.m7g.4xlarge), docker-builds / docker-build (linux.12xlarge, pytorch-linux-jammy-py3-clang12-executorch), docker-builds / docker-build (pytorch-linux-jammy-aarch64-py3.10-gcc13-inductor-benchmarks, linux.arm64.m7g.4xlar..., docker-builds / docker-build (pytorch-linux-jammy-aarch64-py3.10-clang21, linux.arm64.m7g.4xlarge), pull / linux-jammy-py3.10-clang12-onnx / test (default, 1, 2, linux.c7i.2xlarge), pull / linux-jammy-py3.10-clang12-onnx / test (default, 2, 2, linux.c7i.2xlarge) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 1 jobs have failed, first few of them are: trunk / linux-jammy-py3-clang12-executorch / build Details for Dev Infra teamRaised by workflow job |
|
@pytorchbot merge -f "infra failures" |
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable" -c autorevert This PR is attributed to have caused regression in: Please investigate and fix the issues. |
|
@pytorchbot successfully started a revert job. Check the current status here. |
…obs (#167395)" This reverts commit 4ed26f7. Reverted #167395 on behalf of https://github.com/pytorch-auto-revert due to Reverted automatically by pytorch's autorevert, to avoid this behaviour add the tag autorevert: disable ([comment](#167395 (comment)))
|
@d4l3k your PR has been successfully reverted. |
This adds a debug HTTP server for debugging stuck or slow jobs. It runs the WorkerServer on every worker and then launches a separate flask process on rank 0 to have users connect to for debugging.
This can easily be improved to trigger profilers as well as visualize the data much better.
Initial handlers:
Test plan:
cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @pragupta @msaroufim @dcci