Skip to content

Conversation

@aorenste
Copy link
Contributor

@aorenste aorenste commented Nov 11, 2025

The previous work to decompose missing sympy.SymExpr (#164717) handled combinations of sub-nodes (like s1*s2) but I forgot to handle explicit literals (like 2*s2).

Added a unit test based on the report.

Fixes T244632748

Stack from ghstack (oldest at bottom):

cc @ezyang @EikanWang @jgong5 @wenzhe-nrv

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 11, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167585

Note: Links to docs will display an error until the docs builds have been completed.

✅ You can merge normally! (1 Unrelated Failure)

As of commit b8b966c with merge base 5b6ff81 (image):

UNSTABLE - The following job is marked as unstable, possibly due to flakiness on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor release notes: fx release notes category labels Nov 11, 2025
aorenste added a commit that referenced this pull request Nov 11, 2025
…onstant literals

ghstack-source-id: 0ffc265
Pull Request resolved: #167585
@aorenste aorenste changed the title ProxyTorchDispatchMode: Decomposing missing sym exprs should handle constant literals ProxyTorchDispatchMode: Decomposing missing sympy.SymExpr should handle constant literals Nov 11, 2025
@aorenste aorenste marked this pull request as ready for review November 11, 2025 22:47
…should handle constant literals"

The previous work to decompose missing sympy.SymExpr (#164717) handled combinations of sub-nodes (like `s1*s2`) but I forgot to handle explicit literals (like `2*s2`).

Added a unit test based on the report.

Fixes T244632748




cc ezyang EikanWang jgong5 wenzhe-nrv

[ghstack-poisoned]
aorenste added a commit that referenced this pull request Nov 12, 2025
…onstant literals

ghstack-source-id: bc71f70
Pull Request resolved: #167585
@aorenste
Copy link
Contributor Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 12, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request fx Merged release notes: fx release notes category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants