Skip to content

Conversation

@hinriksnaer
Copy link
Contributor

@hinriksnaer hinriksnaer commented Nov 13, 2025

Remove deprecated split_cat_fx_passes

First of a couple of small PRs that remove deprecated and unused code.

Remove the deprecated split_cat_fx_passes configuration variable from inductor config and clean up associated test patches.

Changes

  • Remove split_cat_fx_passes from torch/_inductor/config.py
  • Remove @patch.object(config, "split_cat_fx_passes", False) decorators from tests in test/inductor/test_perf.py

cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov @coconutruben

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/167738

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit f261290 with merge base 2c846bb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

The label module: inductor is only applicable to issues and has been removed. Please only use this label on issues.

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

The label module: inductor is only applicable to issues and has been removed. Please only use this label on issues.

@hinriksnaer hinriksnaer changed the title [Inductor] Removed deprecated split_cat_fx_passes Removed deprecated split_cat_fx_passes Nov 13, 2025
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 13, 2025

The label module: inductor is only applicable to issues and has been removed. Please only use this label on issues.

@hinriksnaer
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Nov 13, 2025
@jerryzh168 jerryzh168 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Nov 14, 2025
@cyyever
Copy link
Collaborator

cyyever commented Nov 24, 2025

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 24, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 0 checks:

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

zhudada0120 pushed a commit to zhudada0120/pytorch that referenced this pull request Nov 25, 2025
  ## Remove deprecated `split_cat_fx_passes`

First of a couple of small PRs that remove deprecated and unused code.

Remove the deprecated `split_cat_fx_passes` configuration variable from inductor config and clean up associated test patches.

  ### Changes
  - Remove `split_cat_fx_passes` from `torch/_inductor/config.py`
  - Remove `@patch.object(config, "split_cat_fx_passes", False)` decorators from tests in `test/inductor/test_perf.py`

Pull Request resolved: pytorch#167738
Approved by: https://github.com/jansel, https://github.com/eellison, https://github.com/cyyever
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged open source topic: not user facing topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants