-
Notifications
You must be signed in to change notification settings - Fork 26k
[DTensor] Refactor strategy/rule registration into dedicated module #168221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
To avoid circular import issues: - utils.py used to include registration functions which import/depend on DTensor.sharding_propagator - I plan to use other utils from utils.py inside sharding_propagator.py [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168221
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 New FailuresAs of commit 557fedc with merge base 6edf2aa ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ed module" To avoid circular import issues: - utils.py used to include registration functions which import/depend on DTensor.sharding_propagator - I plan to use other utils from utils.py inside sharding_propagator.py [ghstack-poisoned]
| ) | ||
|
|
||
|
|
||
| # convenient wrapper to register sharding propagation rules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no code change, i promise. just moved from other file
albanD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok!
|
@pytorchbot merge -I |
|
❌ 🤖 pytorchbot command failed: Try |
|
@pytorchbot merge -i |
Merge startedYour change will be merged while ignoring the following 2 checks: pull / linux-jammy-rocm-py3.10 / build, inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx) Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Changed in PyTorch as part of pytorch/pytorch#168221
Changed in PyTorch as part of pytorch/pytorch#168221
Stack from ghstack (oldest at bottom):
To avoid circular import issues:
DTensor.sharding_propagator