Skip to content

Conversation

@wconstab
Copy link
Contributor

@wconstab wconstab commented Nov 20, 2025

Stack from ghstack (oldest at bottom):

To avoid circular import issues:

  • utils.py used to include registration functions which import/depend on
    DTensor.sharding_propagator
  • I plan to use other utils from utils.py inside sharding_propagator.py

To avoid circular import issues:
- utils.py used to include registration functions which import/depend on
  DTensor.sharding_propagator
- I plan to use other utils from utils.py inside sharding_propagator.py

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 20, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/168221

Note: Links to docs will display an error until the docs builds have been completed.

❌ 3 New Failures

As of commit 557fedc with merge base 6edf2aa (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…ed module"

To avoid circular import issues:
- utils.py used to include registration functions which import/depend on
  DTensor.sharding_propagator
- I plan to use other utils from utils.py inside sharding_propagator.py

[ghstack-poisoned]
)


# convenient wrapper to register sharding propagation rules
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no code change, i promise. just moved from other file

Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok!

@wconstab
Copy link
Contributor Author

@pytorchbot merge -I

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 23, 2025

❌ 🤖 pytorchbot command failed:

@pytorchbot: error: unrecognized arguments: -I

usage: @pytorchbot [-h] {merge,revert,rebase,label,drci,cherry-pick} ...

Try @pytorchbot --help for more info.

@wconstab
Copy link
Contributor Author

@pytorchbot merge -i

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Nov 23, 2025
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged while ignoring the following 2 checks: pull / linux-jammy-rocm-py3.10 / build, inductor / inductor-cpu-test / test (cpu_inductor_torchbench, 1, 2, linux.2xlarge.amx)

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

aditvenk added a commit to aditvenk/autoparallel that referenced this pull request Nov 25, 2025
xmfan pushed a commit to meta-pytorch/autoparallel that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants