Merge binaries "convert_image_to_tensor" and "caffe2_benchmark" #16875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move the overhead of writing to/reading from Tensor file.
There was a problem hiding this comment.
@ZhizhenQin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
@ZhizhenQin has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
pearu
pushed a commit
to Quansight/pytorch
that referenced
this pull request
Feb 12, 2019
…rch#16875) Summary: Merge binaries "convert_image_to_tensor" and "caffe2_benchmark" to remove the overhead of writing to/reading from Tensor file. *TODO next: TensorProtos is another overhead. No need for de-serialization. Pull Request resolved: pytorch#16875 Reviewed By: sf-wind Differential Revision: D13997726 Pulled By: ZhizhenQin fbshipit-source-id: 4dec17f0ebb59cf1438b9aba5421db2b41c47a9f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge binaries "convert_image_to_tensor" and "caffe2_benchmark" to remove the overhead of writing to/reading from Tensor file.
*TODO next: TensorProtos is another overhead. No need for de-serialization.