Refine return type Stream to HIPStream in HIPStreamGuardMasqueradingAsCUDA #16978
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sCUDA Previously, we used the templated class directly to provide implementations. However, there is a subtle difference between this, and CUDAStream: CUDAStream has refined types for the Streams it returns. This lead to a compilation failure of HIPified ddp.cpp. This commit lines them up more closely, at the cost of copy-paste. A possible alternate strategy would have been to extend the InlineDeviceGuard templates to optionally accept refinements for Stream. I leave this for future work. Signed-off-by: Edward Z. Yang <ezyang@fb.com>
|
@ezyang Looks good, or do we need to rerun CI? |
|
@pytorchbot retest this please |
|
CI coverage looks sufficient |
There was a problem hiding this comment.
@ezyang is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
zdevito
pushed a commit
to zdevito/ATen
that referenced
this pull request
Feb 12, 2019
…sCUDA (#16978) Summary: Previously, we used the templated class directly to provide implementations. However, there is a subtle difference between this, and CUDAStreamGuard: CUDAStreamGuard has refined types for the Streams it returns. This lead to a compilation failure of HIPified ddp.cpp. This commit lines them up more closely, at the cost of copy-paste. A possible alternate strategy would have been to extend the InlineDeviceGuard templates to optionally accept refinements for Stream. I leave this for future work. Signed-off-by: Edward Z. Yang <ezyang@fb.com> Pull Request resolved: pytorch/pytorch#16978 Differential Revision: D14045346 Pulled By: ezyang fbshipit-source-id: 2b101606e62e4db588027c57902ea739a2119410
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we used the templated class directly to provide
implementations. However, there is a subtle difference
between this, and CUDAStreamGuard: CUDAStreamGuard has refined types
for the Streams it returns. This lead to a compilation failure
of HIPified ddp.cpp. This commit lines them up more closely,
at the cost of copy-paste.
A possible alternate strategy would have been to extend the
InlineDeviceGuard templates to optionally accept refinements
for Stream. I leave this for future work.
Signed-off-by: Edward Z. Yang ezyang@fb.com