Remove fake inference for shape info in ONNXIFI transform #17046
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Summary: Pull Request resolved: pytorch#17046 As we are moving to use bound shape inference, we can remove the awkward fake inference run path and make the code cleaner. Differential Revision: D14061501 fbshipit-source-id: 7c405fcf1e46196ace7932cb0eb11e1404867a95
yinghai
force-pushed
the
export-D14061501
branch
from
2815405 to
93425cc
Compare
zou3519
added a commit
to zou3519/pytorch
that referenced
this pull request
Mar 12, 2019
) Summary: Pull Request resolved: pytorch#17046 As we are moving to use bound shape inference, we can remove the awkward fake inference run path and make the code cleaner. Reviewed By: ipiszy Differential Revision: D14061501 fbshipit-source-id: b3ace98b3dabef3c3359086a0bb1410518cefa26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: As we are moving to use bound shape inference, we can remove the awkward fake inference run path and make the code cleaner.
Differential Revision: D14061501