Fix lint in test_dataloader.py #17820
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: D14392864 Differential Version: 74816080
This was referenced Mar 8, 2019
vishwakftw
reviewed
Mar 9, 2019
| loader = DataLoader(self.dataset, batch_size=2, collate_fn=collate_wrapper, | ||
| pin_memory=True) | ||
| for batch_ndx, sample in enumerate(loader): | ||
| for _sample in loader: |
There was a problem hiding this comment.
Minor nit here: _sample -> sample
|
@ezyang The nit seems to have broken tests on master. |
|
Crap, reverting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack:
:white_circle: #17813 Suppress C408 lint (don't use dict constructor) 💛
:black_circle: #17820 Fix lint in test_dataloader.py 💚
:white_circle: #17821 Fix lint in test_distributions.py 💛
:white_circle: #17823 Fix lint in test_jit.py 💛
Differential Revision: D14392864